From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: andriy.shevchenko@linux.intel.com,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
mika.westerberg@linux.intel.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] of/property: Add of_fwnode_name()
Date: Mon, 12 Nov 2018 17:05:46 +0200 [thread overview]
Message-ID: <20181112150546.GC1677@kuha.fi.intel.com> (raw)
In-Reply-To: <CABGGiswFe92TLtU6YH3UsQJBbACbHu2w0rmc7FvwURqi_PU+7w@mail.gmail.com>
Hi,
On Fri, Nov 09, 2018 at 10:14:49AM -0600, Rob Herring wrote:
> > I would prefer that we had something like of_node_name_get() function
> > that of_fwnode_get_name() could simply call. I don't know how you want
> > that implemented, but I'm expecting you will implement something like
> > that in any case once you start removing that ->name member. I figured
> > that at that point we can update of_fwnode_get_name() as well.
>
> I don't plan to implement anything like that. Here's what I'm planning:
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/log/?h=dt/testing
>
> Which is eliminating the need to access .name by: using %pOFn (mostly
> in 4.20), using of_node_name_eq() wrapper, or using full_name instead.
> The last case generally is cases where the name is not important such
> as request_irq() or irq_chip.name.
OK. Thanks for the explanation.
thanks,
--
heikki
next prev parent reply other threads:[~2018-11-12 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:51 [PATCH v2 0/4] device property: Add fwnode_get_name() helper Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 1/4] device property: Introduce fwnode_get_name() Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 2/4] ACPI: property: Add acpi_fwnode_name() Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 3/4] of/property: Add of_fwnode_name() Heikki Krogerus
2018-11-08 18:23 ` Rob Herring
2018-11-08 19:25 ` Andy Shevchenko
2018-11-08 21:18 ` Rob Herring
2018-11-09 13:34 ` Heikki Krogerus
2018-11-09 16:14 ` Rob Herring
2018-11-12 15:05 ` Heikki Krogerus [this message]
2018-11-08 16:51 ` [PATCH v2 4/4] device property: Drop get_named_child_node callback Heikki Krogerus
2018-11-20 22:03 ` [PATCH v2 0/4] device property: Add fwnode_get_name() helper Rafael J. Wysocki
2018-11-21 12:36 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112150546.GC1677@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox