Re: [PATCH v2 00/25] at24: remove

Bartosz Golaszewski
2018-11-13T14:04:37Z

wt., 13 lis 2018 o 15:01 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Now that nvmem has gained support for defining cells from board files and
> looking them up from relevant drivers[1], it's time for a respin of the
> previous series[2] that aims at removing struct at24_platform_data from
> the tree.
>
> Since I took over maintainership of the at24 driver I've been working
> towards removing at24_platform_data in favor for device properties.
>
> DaVinci is the only platform that's still using it - all other users
> have already been converted.
>
> One of the obstacles in case of DaVinci is removing the setup() callback
> from the pdata struct, the only user of which are some davinci boards.
>
> First we add support for nvmem to MTD in a way previously discussed with
> Boris Brezillon and Srinivas Kandagatla.
>
> Then, since most boards use the EEPROM to store the MAC address, we register
> relevant cells for all users, implement a function that allows to read
> the MAC address from nvmem (and also replaces the previous DT-specific
> variant) and make davinci_emac aware of it.
>
> Next we switch all davinci users to using at24 device properties instead
> of platform data. While we're at it: we remove all other traces of the
> setup callback and platform data from davinci.
>
> Finally we remove the at24 platform data structure.
>
> I kept the review tags in patches that haven't changed from the last
> submission.
>
> As far as merging of this series goes: I'd like to avoid dragging it over
> four releases. The series is logically split into five groups:
>
> patches 1-2: nvmem and mtd changes
> patches 3-9: davinci arch-specific changes
> patches 10-13: networking changes
> patches 14-24: davinci specific again
> patch 25: final at24 change
>
> With that I believe we can do the following: Greg KH could pick up the
> first two patches into his char-misc tree. Sekhar would take the second
> group and the third would go through the networking tree since the first
> three sets are not linked in any way. This would be merged for 4.21. Then
> for the next release Sekhar would pick up 14-24, provide an immutable
> branch for me and I'd merge the final patch for at24 and send it upstream
> through Wolfram's i2c tree (maybe we could even delay the i2c PR in the
> merge window to avoid the immutable branch altogether).
>
> [1] https://lkml.org/lkml/2018/9/21/293
> [2] https://lkml.org/lkml/2018/8/8/528
>
> Alban Bedel (1):
> mtd: add support for reading MTD devices via the nvmem API
>
> Bartosz Golaszewski (24):
> nvmem: add new config option
> ARM: davinci: dm365-evm: use cell nvmem lookup for mac address
> ARM: davinci: dm644x-evm: use cell nvmem lookup for mac address
> ARM: davinci: dm646x-evm: use cell nvmem lookup for mac address
> ARM: davinci: da830-evm: use cell nvmem lookup for mac address
> ARM: davinci: mityomapl138: use cell nvmem lookup for mac address
> ARM: davinci: dm850-evm: use cell nvmem lookup for mac address
> ARM: davinci: da850-evm: remove unnecessary include
> net: ethernet: provide nvmem_get_mac_address()
> net: cadence: switch to using nvmem_get_mac_address()
> of: net: kill of_get_nvmem_mac_address()
> net: davinci_emac: use nvmem_get_mac_address()
> ARM: davinci: da850-evm: remove dead MTD code
> ARM: davinci: mityomapl138: don't read the MAC address from machine
> code
> ARM: davinci: dm365-evm: use device properties for at24 eeprom
> ARM: davinci: da830-evm: use device properties for at24 eeprom
> ARM: davinci: dm644x-evm: use device properties for at24 eeprom
> ARM: davinci: dm646x-evm: use device properties for at24 eeprom
> ARM: davinci: sffsdr: fix the at24 eeprom device name
> ARM: davinci: sffsdr: use device properties for at24 eeprom
> ARM: davinci: remove dead code related to MAC address reading
> ARM: davinci: mityomapl138: use nvmem notifiers
> ARM: davinci: mityomapl138: use device properties for at24 eeprom
> eeprom: at24: remove at24_platform_data
>
> MAINTAINERS | 1 -
> arch/arm/mach-davinci/board-da830-evm.c | 39 ++++-
> arch/arm/mach-davinci/board-da850-evm.c | 58 ++++----
> arch/arm/mach-davinci/board-dm365-evm.c | 38 ++++-
> arch/arm/mach-davinci/board-dm644x-evm.c | 37 ++++-
> arch/arm/mach-davinci/board-dm646x-evm.c | 37 ++++-
> arch/arm/mach-davinci/board-mityomapl138.c | 67 ++++++---
> arch/arm/mach-davinci/board-sffsdr.c | 13 +-
> arch/arm/mach-davinci/common.c | 15 --
> drivers/misc/eeprom/at24.c | 162 ++++++++++-----------
> drivers/mtd/Kconfig | 1 +
> drivers/mtd/mtdcore.c | 56 +++++++
> drivers/net/ethernet/cadence/macb_main.c | 2 +-
> drivers/net/ethernet/ti/davinci_emac.c | 14 +-
> drivers/nvmem/core.c | 3 +-
> drivers/of/of_net.c | 39 -----
> include/linux/davinci_emac.h | 1 -
> include/linux/etherdevice.h | 1 +
> include/linux/mtd/mtd.h | 2 +
> include/linux/nvmem-provider.h | 2 +
> include/linux/of_net.h | 6 -
> include/linux/platform_data/at24.h | 60 --------
> net/ethernet/eth.c | 38 +++++
> 23 files changed, 391 insertions(+), 301 deletions(-)
> delete mode 100644 include/linux/platform_data/at24.h
>
> --
> 2.19.1
>

Ugh the subject was supposed to be: at24: remove platform data...