From: Oleg Nesterov <oleg@redhat.com>
To: Roman Gushchin <guro@fb.com>
Cc: Roman Gushchin <guroan@gmail.com>, Tejun Heo <tj@kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v2 3/6] cgroup: cgroup v2 freezer
Date: Wed, 14 Nov 2018 18:36:11 +0100 [thread overview]
Message-ID: <20181114173610.GF13885@redhat.com> (raw)
In-Reply-To: <20181114170558.GA24889@castle.DHCP.thefacebook.com>
On 11/14, Roman Gushchin wrote:
>
> > No, this is very wrong. Just suppose the caller is killed right before
> > clear_thread_flag(TIF_SIGPENDING).
>
> So, I had TASK_KILLABLE before, but had some issues with ptrace/gdb.
> I'll revisit this option.
Yes, ptrace_signal_wake_up() won't wake a TASK_KILLABLE tracee up...
BTW. Could you explain in the changelog how should a frozen task interact
with ptrace? 0/6 says "ptrace works" but that is all. It is not clear to me
what do we actually want wrt ptrace...
Oleg.
next prev parent reply other threads:[~2018-11-14 17:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 23:04 [PATCH v2 0/6] freezer for cgroup v2 Roman Gushchin
2018-11-12 23:04 ` [PATCH] cgroup: document cgroup v2 freezer interface Roman Gushchin
2018-11-12 23:04 ` [PATCH v2 1/6] cgroup: rename freezer.c into legacy_freezer.c Roman Gushchin
2018-11-12 23:04 ` [PATCH v2 2/6] cgroup: implement __cgroup_task_count() helper Roman Gushchin
2018-11-12 23:04 ` [PATCH v2 3/6] cgroup: cgroup v2 freezer Roman Gushchin
2018-11-13 2:08 ` Tejun Heo
2018-11-13 18:47 ` Roman Gushchin
2018-11-13 19:15 ` Tejun Heo
2018-11-13 20:55 ` Roman Gushchin
2018-11-13 20:58 ` Tejun Heo
2018-11-13 15:37 ` Oleg Nesterov
2018-11-13 15:43 ` Tejun Heo
2018-11-13 16:00 ` Oleg Nesterov
2018-11-13 15:48 ` Oleg Nesterov
2018-11-13 21:59 ` Roman Gushchin
2018-11-14 16:56 ` Oleg Nesterov
2018-11-14 17:06 ` Roman Gushchin
2018-11-14 17:36 ` Oleg Nesterov [this message]
2018-11-14 17:39 ` Roman Gushchin
2018-11-28 17:36 ` Roman Gushchin
2018-11-12 23:04 ` [PATCH v2 4/6] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy() Roman Gushchin
2018-11-12 23:04 ` [PATCH v2 5/6] kselftests: cgroup: add freezer controller self-tests Roman Gushchin
2018-11-12 23:04 ` [PATCH v2 6/6] cgroup: document cgroup v2 freezer interface Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114173610.GF13885@redhat.com \
--to=oleg@redhat.com \
--cc=Kernel-team@fb.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=guroan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox