From: "Michael Büsch" <m@bues.ch>
To: Priit Laes <plaes@plaes.org>
Cc: Kees Cook <keescook@chromium.org>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Colin Ian King <colin.king@canonical.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Varsha Rao <rvarsha016@gmail.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] b43: Use cordic algorithm from kernel library
Date: Wed, 14 Nov 2018 19:46:28 +0100 [thread overview]
Message-ID: <20181114194628.0f485637@wiggum> (raw)
In-Reply-To: <d93962cdc5a32fe99e6e5a25172920d28583aa6a.1542219596.git-series.plaes@plaes.org>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On Wed, 14 Nov 2018 20:27:52 +0200
Priit Laes <plaes@plaes.org> wrote:
> Kernel library has a common cordic algorithm which is identical
> to internally implementatd one, so use it and drop the duplicate
> implementation.
In v2 of the series it has been said that:
Arend van Spriel <arend.vanspriel@broadcom.com> wrote:
> I recall doing a comparison between the algorithms and thought I put
> that in the original commit message. However, it is not there. It is not
> exactly the same as in b43 so there are difference for certain angles,
> most results are the same however. This implementation is slightly more
> accurate on the full scale.
That's not my definition of "identical".
Please do not apply this patch without doing a thorough regression test
on actual b43 LP hardware.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-14 18:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 18:27 [PATCH v3 0/3] wireless: Use common cordic algorithm for b43 driver Priit Laes
2018-11-14 18:27 ` [PATCH v3 1/3] lib: cordic: Move cordic macros and defines to header file Priit Laes
2018-11-14 18:27 ` [PATCH v3 2/3] brcmsmac: Use cordic-related macros from common cordic library Priit Laes
2018-11-14 18:27 ` [PATCH v3 3/3] b43: Use cordic algorithm from kernel library Priit Laes
2018-11-14 18:46 ` Michael Büsch [this message]
2018-11-17 8:36 ` Priit Laes
2018-11-17 11:06 ` Kalle Valo
2018-11-18 3:31 ` Larry Finger
2018-11-18 8:23 ` Priit Laes
2018-11-18 19:35 ` Larry Finger
2018-11-19 10:43 ` Kalle Valo
2018-11-19 11:14 ` Priit Laes
2018-11-19 17:41 ` Larry Finger
2018-11-19 11:27 ` Priit Laes
2018-11-19 17:40 ` Larry Finger
2018-11-15 11:09 ` [PATCH v3 0/3] wireless: Use common cordic algorithm for b43 driver Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114194628.0f485637@wiggum \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=arend.vanspriel@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@gmail.com \
--cc=colin.king@canonical.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=plaes@plaes.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox