From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9775C04EBF for ; Thu, 15 Nov 2018 15:03:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94439223DD for ; Thu, 15 Nov 2018 15:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xACi84vS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94439223DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388547AbeKPBLf (ORCPT ); Thu, 15 Nov 2018 20:11:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:33378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388374AbeKPBLf (ORCPT ); Thu, 15 Nov 2018 20:11:35 -0500 Received: from localhost (unknown [64.114.255.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BDF620818; Thu, 15 Nov 2018 15:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542294202; bh=F/l6jhD/ixFjgGEsTyXtJ0dblKRni2Q43VjvZssafm4=; h=Date:From:To:Subject:References:In-Reply-To:From; b=xACi84vSc0pKRBtpRbj/6Yk/F2MfLW+RucoMXjrg4IHlQa7fWTa3b7bxNCociTbve 3Xpv4h0Clz3Jf46q31DdIU0wbcUFVlD5IyWbdSNinop4VACP/pPTvUgIysiSqBT5wP /xNUraPx4+VezSh6oRsMdLI9Gdd29TgQdq9jSF6Q= Date: Thu, 15 Nov 2018 09:03:21 -0600 From: Bjorn Helgaas To: Borislav Petkov , pr-tracker-bot@kernel.org, Linus Torvalds , Greg Kroah-Hartman , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Thomas Lendacky , Ingo Molnar , Jonathan Cameron , Thomas Gleixner , Peter Zijlstra , Martin =?iso-8859-1?Q?Hundeb=F8ll?= , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Subject: Re: [GIT PULL] PCI fixes for v4.20 Message-ID: <20181115150321.GB207836@google.com> References: <20181114062010.GA189193@google.com> <20181114200003.14496.1490.pr-tracker-bot@pdx-korg-gitolite-1.ci.codeaurora.org> <20181114201214.GM13926@zn.tnic> <20181114201658.GB25069@pure.paranoia.local> <20181114214601.GO13926@zn.tnic> <20181114222154.GA22445@pure.paranoia.local> <20181114224839.GP13926@zn.tnic> <20181115071252.GB94998@google.com> <20181115075330.GA32162@pure.paranoia.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115075330.GA32162@pure.paranoia.local> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 15, 2018 at 02:53:30AM -0500, Konstantin Ryabitsev wrote: > On Thu, Nov 15, 2018 at 01:12:53AM -0600, Bjorn Helgaas wrote: > > > and I kinda see the point of maybe not having your ssh username in the > > > URL. Not that it is a big deal for us, k.org users though. > > > > Sorry, I don't understand the problem. I have this in my .gitconfig: > > > > [url "ssh://git@gitolite.kernel.org"] > > insteadOf = https://git.kernel.org > > insteadOf = http://git.kernel.org > > insteadOf = git://git.kernel.org > > > > because I thought that was the recommended way (see the end of > > https://korg.wiki.kernel.org/userdoc/gitolite). But that also makes my > > request-pull: > > > > $ git request-pull origin/master git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci-v4.20-fixes-1 > > > > generate the ssh URL above. If I remove the insteadOf stuff from > > .gitconfig, request-pull produces this instead: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-v4.20-fixes-1 > > > > I'm happy to do either; just tell me which :) > > You didn't really do anything wrong. In *general* I prefer to see > public URLs if they are sent to public lists, so if you're cc'ing > something to LKML, I would generally expect the pull request to have a > public URL like https://git.kernel.org/ instead of a private ssh:// URL > that is only accessible to people with a kernel.org account. > > That's basically all there is to it. It doesn't *really* matter, since > Linus is the one who will be merging the actual pull request, and he > certainly has access to internal ssh:// URLs. However, in case someone > else was interested in reviewing the pull request, it would be more > friendly to have a public URL for them. OK, I think I'll remove the insteadOf chunk from my .gitconfig. Should https://korg.wiki.kernel.org/userdoc/gitolite be updated to remove or expand that recommendation? The only reason I added insteadOf in the first place was because it sounded like a security improvement. Bjorn