Re: [PATCH V10 05/19] block: introduce bvec_last_segment()

Christoph Hellwig
2018-11-16T13:34:31Z

> + unsigned last_page = total / PAGE_SIZE;
> +
> + if (last_page * PAGE_SIZE == total)

Not sure it matters much with modern compilers, but generally
we shit by PAGE_SHIFT instead of multiplying with or dividing
by PAGE_SIZE.