From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Grant Grundler <grundler@chromium.org>,
Wen Gong <wgong@codeaurora.org>, <linux-kernel@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH 4.20] ath10k: don't assume 'vif' is non-NULL in flush()
Date: Fri, 16 Nov 2018 13:08:42 +0000 (UTC) [thread overview]
Message-ID: <20181116130842.09750607F5@smtp.codeaurora.org> (raw)
In-Reply-To: <20181108004035.136050-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> mac80211 may call us with vif == NULL, if the station is not currently
> active (e.g., not associated). It is trivially easy to reproduce a crash
> by suspending the system when not connected to an AP:
>
> [ 65.533934] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
> ...
> [ 65.574521] pc : ath10k_flush+0x30/0xd0 [ath10k_core]
> [ 65.574538] lr : __ieee80211_flush_queues+0x180/0x244 [mac80211]
> [ 65.599680] Process kworker/u12:1 (pid: 57, stack limit = 0x(____ptrval____))
> [ 65.599682] Call trace:
> [ 65.599695] ath10k_flush+0x30/0xd0 [ath10k_core]
> [ 65.642064] __ieee80211_flush_queues+0x180/0x244 [mac80211]
> [ 65.642079] ieee80211_flush_queues+0x34/0x40 [mac80211]
> [ 65.642095] __ieee80211_suspend+0xfc/0x47c [mac80211]
> [ 65.658611] ieee80211_suspend+0x30/0x3c [mac80211]
> [ 65.658627] wiphy_suspend+0x15c/0x3a8 [cfg80211]
> [ 65.672810] dpm_run_callback+0xf0/0x1f0
> [ 65.672814] __device_suspend+0x3ac/0x4f8
> [ 65.672819] async_suspend+0x34/0xbc
> [ 65.684096] async_run_entry_fn+0x54/0x104
> [ 65.684099] worker_thread+0x4cc/0x72c
> [ 65.684102] kthread+0x134/0x13c
> [ 65.684105] ret_from_fork+0x10/0x18
>
> Fixes: 9de4162f0999 ("ath10k: add peer flush in ath10k_flush for STATION")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers.git, thanks.
d987f783a480 ath10k: don't assume 'vif' is non-NULL in flush()
--
https://patchwork.kernel.org/patch/10673301/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-11-16 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 0:40 [PATCH 4.20] ath10k: don't assume 'vif' is non-NULL in flush() Brian Norris
2018-11-16 13:08 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116130842.09750607F5@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=grundler@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox