From: Jiri Olsa <jolsa@redhat.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
acme@kernel.org, alexander.shishkin@linux.intel.com,
namhyung@kernel.org, mathieu.poirier@linaro.org,
mingo@kernel.org
Subject: Re: [PATCH] perf build: fix -lbfd feature check
Date: Fri, 16 Nov 2018 14:34:20 +0100 [thread overview]
Message-ID: <20181116133420.GA29750@krava> (raw)
In-Reply-To: <4dfc634cfcfb236883971b5107cf3c28ec8a31be.1542328222.git.sdf@google.com>
On Thu, Nov 15, 2018 at 04:32:01PM -0800, Stanislav Fomichev wrote:
> Current libbfd feature test unconditionally links against -liberty and -lz.
> While it's required on some systems (e.g. opensuse), it's completely
> unnecessary on the others, where only -lbdf is sufficient (debian).
> This patch streamlines (and renames) the following feature checks:
>
> feature-libbfd - only link against -lbfd (debian),
> see commit 2cf9040714f3 ("perf tools: Fix bfd
> dependency libraries detection")
> feature-libbfd-liberty - link against -lbfd and -liberty
> feature-libbfd-liberty-z - link against -lbfd, -liberty and -lz (opensuse),
> see commit 280e7c48c3b8 ("perf tools: fix BFD
> detection on opensuse")
>
> (feature-liberty{,-z} were renamed to feature-libbfd-liberty{,z}
> for clarity)
>
> The main motivation is to fix this feature test for bpftool which is
> currently broken on debian (libbfd feature shows OFF, but we still
> unconditionally link against -lbfd and it works).
>
> Tested on debian with only -lbfd installed (without -liberty); I'd
> appreciate if somebody on the other systems can test this new detection
> method.
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
looks good, Fedora goes with standalone libbfd
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2018-11-16 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 0:32 [PATCH] perf build: fix -lbfd feature check Stanislav Fomichev
2018-11-16 13:34 ` Jiri Olsa [this message]
2018-12-19 2:08 ` Stanislav Fomichev
2019-01-03 13:11 ` [tip:perf/urgent] perf build: Don't unconditionally link the libbfd feature test to -liberty and -lz tip-bot for Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116133420.GA29750@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox