From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E5AC43441 for ; Fri, 16 Nov 2018 18:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F257206BA for ; Fri, 16 Nov 2018 18:14:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F257206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jic23.retrosnub.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729317AbeKQE2M (ORCPT ); Fri, 16 Nov 2018 23:28:12 -0500 Received: from saturn.retrosnub.co.uk ([46.235.226.198]:59546 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727462AbeKQE2M (ORCPT ); Fri, 16 Nov 2018 23:28:12 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id AC4359E7841; Fri, 16 Nov 2018 18:14:43 +0000 (GMT) Date: Fri, 16 Nov 2018 18:14:42 +0000 From: Jonathan Cameron To: Matthias Kaehlcke Cc: Andy Gross , David Brown , Rob Herring , Mark Rutland , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example Message-ID: <20181116181442.0c2ce602@archlinux> In-Reply-To: <20181116181338.52674a46@archlinux> References: <20181112221126.27142-1-mka@chromium.org> <20181112221126.27142-2-mka@chromium.org> <20181116181338.52674a46@archlinux> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Nov 2018 18:13:38 +0000 Jonathan Cameron wrote: > On Mon, 12 Nov 2018 14:11:25 -0800 > Matthias Kaehlcke wrote: > > > The node has a reg property, therefore its name should include a unit > > address. Also change the name from 'usb_id_nopull' to 'adc-chan', which > > is the preferred name for ADC channel nodes. > > > > Include headers for constants used in the example. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Douglas Anderson > Looks good to me. I'd just like to leave it a little longer > to give Rob or other device tree specialists a change > to take one last look at it. > > Ping me if I seem to have forgotten about it! > Ah, I should have read on. Already queued. That's fine with me. Jonathan > Thanks, > > Jonathan > > --- > > Changes in v6: > > - changed node name to adc-chan@ > > - added includes for constants used in the example > > - updated commit message > > - added 'Reviewed-by: Douglas Anderson ' tag > > > > Changes in v5: > > - patch added to the series > > --- > > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > > index b3c86f4ac7cdb..c81993f8d8c39 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > > @@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC. > > > > Example: > > > > +#include > > +#include > > +/* ... */ > > + > > /* VADC node */ > > pmic_vadc: vadc@3100 { > > compatible = "qcom,spmi-vadc"; > > @@ -151,7 +155,7 @@ Example: > > io-channel-ranges; > > > > /* Channel node */ > > - usb_id_nopull { > > + adc-chan@VADC_LR_MUX10_USB_ID { > > reg = ; > > qcom,decimation = <512>; > > qcom,ratiometric; >