From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C61C43441 for ; Sat, 17 Nov 2018 00:38:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04F06208E3 for ; Sat, 17 Nov 2018 00:38:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iNzTRdk0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04F06208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730895AbeKQKxQ (ORCPT ); Sat, 17 Nov 2018 05:53:16 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40792 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730522AbeKQKxN (ORCPT ); Sat, 17 Nov 2018 05:53:13 -0500 Received: by mail-pf1-f196.google.com with SMTP id x2-v6so12141628pfm.7; Fri, 16 Nov 2018 16:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FP20pGgu3D25STEzu2nQYXaFb5vqYhGB0+bCEyu/01c=; b=iNzTRdk0yuYBN+kvPn5uD7KxWfVo1DMs4393HJpt/jB2VQAwiSoOAKJt6WXvr2U2b+ cZrw59w+Nam8KbpzGc1kYCs0XagP/ho69sdbDQJfaT5G+GqOwkC+X6DZSnMvDUThIgFj GKe8gHUb32zcy3EPdZ5PooE/NeHjzcUdiPBZLYqIQCL4heoDVlz0tPAQ+OotgSODVlt/ HgTaX+BuzPWtHnFoPqAQG9kD9RiOIPNb5/ha+BUHWM/gHr3YEJmvwUd43/5iN7lLu9eX mTRQCFMnm4GQppjjzul6/hQanR1pm/7fpcVQjCUroFGayPw7VtITj3TekYVAvxvt/5oG HBHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FP20pGgu3D25STEzu2nQYXaFb5vqYhGB0+bCEyu/01c=; b=Jnb8f0LUoi8D81ZtwZiUbnPsu9z780RCEvV5GXZMAVJ8wa6drjB779bDuvflQdgjeo EhT/9JdorPYkCYr8Qy1uFRmuQza8wCUVxtdw4IdoK1oDXGX/7dY3a2J6QQzwDqpcxxB3 hctbYNZQphEOMfldYQPi51uhm/LwIqmD5J5gMIg0mj3RFPJe0Iwer/M11cEqmYojr5Yx 2hEXTVheukdihtPTXoQ0EAHf5L0IsstxXOkbg5d3XLtUXNtZ2RXWlOc3Hqa5vot7pgl5 GHEeNO2H4mtZkjEzRJKNiCFoNKED2rBWwJE//Zy27/HIdMG2P3cSq8k248KBn/cfgMVb 0wkw== X-Gm-Message-State: AGRZ1gI+pmtRQ5LBxMblmDxkDlQLvs9k9lzRjWKd/l1TLbLkV7fVmuZa j2AfjD9nGSmTpZRk1TYBGII= X-Google-Smtp-Source: AJdET5eNKUqwVux0EWRcHKWiPst0L9kSd7+fq02LMIL7Mn03v4mCPV7Wk23t0fcv2jwgyPjcn7Yymw== X-Received: by 2002:a62:dbc2:: with SMTP id f185mr1703269pfg.235.1542415117001; Fri, 16 Nov 2018 16:38:37 -0800 (PST) Received: from tower.thefacebook.com ([2620:10d:c090:200::4:2b73]) by smtp.gmail.com with ESMTPSA id f6sm1981177pfg.188.2018.11.16.16.38.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Nov 2018 16:38:36 -0800 (PST) From: Roman Gushchin X-Google-Original-From: Roman Gushchin To: Tejun Heo Cc: Oleg Nesterov , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Roman Gushchin Subject: [PATCH v3 2/7] cgroup: implement __cgroup_task_count() helper Date: Fri, 16 Nov 2018 16:38:25 -0800 Message-Id: <20181117003830.15344-3-guro@fb.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181117003830.15344-1-guro@fb.com> References: <20181117003830.15344-1-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The helper is identical to the existing cgroup_task_count() except it doesn't take the css_set_lock by itself, assuming that the caller does. Also, move cgroup_task_count() implementation into kernel/cgroup/cgroup.c, as there is nothing specific to cgroup v1. Signed-off-by: Roman Gushchin Cc: Tejun Heo Cc: kernel-team@fb.com --- kernel/cgroup/cgroup-internal.h | 1 + kernel/cgroup/cgroup-v1.c | 16 ---------------- kernel/cgroup/cgroup.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 34 insertions(+), 16 deletions(-) diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h index 75568fcf2180..fe01a9fa4a8d 100644 --- a/kernel/cgroup/cgroup-internal.h +++ b/kernel/cgroup/cgroup-internal.h @@ -224,6 +224,7 @@ int cgroup_rmdir(struct kernfs_node *kn); int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node, struct kernfs_root *kf_root); +int __cgroup_task_count(const struct cgroup *cgrp); int cgroup_task_count(const struct cgroup *cgrp); /* diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c index 51063e7a93c2..6134fef07d57 100644 --- a/kernel/cgroup/cgroup-v1.c +++ b/kernel/cgroup/cgroup-v1.c @@ -336,22 +336,6 @@ static struct cgroup_pidlist *cgroup_pidlist_find_create(struct cgroup *cgrp, return l; } -/** - * cgroup_task_count - count the number of tasks in a cgroup. - * @cgrp: the cgroup in question - */ -int cgroup_task_count(const struct cgroup *cgrp) -{ - int count = 0; - struct cgrp_cset_link *link; - - spin_lock_irq(&css_set_lock); - list_for_each_entry(link, &cgrp->cset_links, cset_link) - count += link->cset->nr_tasks; - spin_unlock_irq(&css_set_lock); - return count; -} - /* * Load a cgroup's pidarray with either procs' tgids or tasks' pids */ diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 4a3dae2a8283..ef3442555b32 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -561,6 +561,39 @@ static void cgroup_get_live(struct cgroup *cgrp) css_get(&cgrp->self); } +/** + * __cgroup_task_count - count the number of tasks in a cgroup. The caller + * is responsible for taking the css_set_lock. + * @cgrp: the cgroup in question + */ +int __cgroup_task_count(const struct cgroup *cgrp) +{ + int count = 0; + struct cgrp_cset_link *link; + + lockdep_assert_held(&css_set_lock); + + list_for_each_entry(link, &cgrp->cset_links, cset_link) + count += link->cset->nr_tasks; + + return count; +} + +/** + * cgroup_task_count - count the number of tasks in a cgroup. + * @cgrp: the cgroup in question + */ +int cgroup_task_count(const struct cgroup *cgrp) +{ + int count; + + spin_lock_irq(&css_set_lock); + count = __cgroup_task_count(cgrp); + spin_unlock_irq(&css_set_lock); + + return count; +} + struct cgroup_subsys_state *of_css(struct kernfs_open_file *of) { struct cgroup *cgrp = of->kn->parent->priv; -- 2.17.2