Re: [PATCH] geneve: Add missing braces in addr6 initializer

Nathan Chancellor
2018-11-12T22:20:20Z

On Mon, Nov 12, 2018 at 11:19:17PM +0100, Stefano Brivio wrote:
> On Mon, 12 Nov 2018 15:12:48 -0700
> Nathan Chancellor <natechancellor@gmail.com> wrote:
>
> > Clang warns:
> >
> > drivers/net/geneve.c:428:29: error: suggest braces around initialization
> > of subobject [-Werror,-Wmissing-braces]
> > struct in6_addr addr6 = { 0 };
> > ^
> > {}
> >
> > Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Thanks for spotting this. By the way, I guess you should indicate in
> the subject when patches are meant for net-next.
>

Sure, I'll be better about that in the future.

> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
>

Thank you for the review!
Nathan

> --
> Stefano