From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648A3C43441 for ; Sat, 17 Nov 2018 21:17:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23D9B20815 for ; Sat, 17 Nov 2018 21:17:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23D9B20815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726958AbeKRHe4 (ORCPT ); Sun, 18 Nov 2018 02:34:56 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49714 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbeKRHe4 (ORCPT ); Sun, 18 Nov 2018 02:34:56 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id B0E38807E5; Sat, 17 Nov 2018 22:16:52 +0100 (CET) Date: Sat, 17 Nov 2018 22:16:54 +0100 From: Pavel Machek To: Sebastian Reichel Cc: Sebastian Reichel , Tomi Valkeinen , Tony Lindgren , Laurent Pinchart , "H. Nikolaus Schaller" , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCHv4 6/6] drm/omap: add support for manually updated displays Message-ID: <20181117211654.GF22813@amd> References: <20181115230645.15748-1-sebastian.reichel@collabora.com> <20181115230645.15748-7-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w3uUfsyyY1Pqa/ej" Content-Disposition: inline In-Reply-To: <20181115230645.15748-7-sebastian.reichel@collabora.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --w3uUfsyyY1Pqa/ej Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2018-11-16 00:06:45, Sebastian Reichel wrote: > This adds the required infrastructure for manually updated displays, > such as DSI command mode panels. While those panels often support > partial updates we currently always do a full refresh. >=20 > The display will be refreshed when something calls the dirty callback, > such as libdrm's drmModeDirtyFB(). This is currently being done at least > by the kernel console and Xorg (with modesetting driver) in their > default configuration. Weston does not implement this and the fbdev > backend does not work (display will not update). Weston's DRM backend > uses double buffering and the page flip will trigger a display refresh > and seems to work as expected. >=20 > Signed-off-by: Sebastian Reichel Acked-by: Pavel Machek > @@ -708,6 +802,18 @@ struct drm_crtc *omap_crtc_init(struct drm_device *d= ev, > omap_crtc->channel =3D channel; > omap_crtc->name =3D channel_names[channel]; > =20 > + /* We want to refresh manually updated displays from dirty callback, Nit: Comment style does not match coding style. /* * =20 --- a/drivers/gpu/drm/omapdrm/omap_fb.c > +++ b/drivers/gpu/drm/omapdrm/omap_fb.c > @@ -66,8 +66,49 @@ struct omap_framebuffer { > struct mutex lock; > }; > =20 > +/* iterate thru all the crts, returning ones that are attached to the sa= me fb */ Start with big letter -- "Iterate"? Thanks, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --w3uUfsyyY1Pqa/ej Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvwhUYACgkQMOfwapXb+vIwmACgmQSHKnhiC3jfU26uR+CQd5Xt g68An2QryM9tFC2f7GFUwfqNXfOx5qv/ =/SeM -----END PGP SIGNATURE----- --w3uUfsyyY1Pqa/ej--