From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D18C43441 for ; Sun, 18 Nov 2018 17:04:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 435322080F for ; Sun, 18 Nov 2018 17:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="s/aFuQ5r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 435322080F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbeKSDZf (ORCPT ); Sun, 18 Nov 2018 22:25:35 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:39528 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbeKSDZf (ORCPT ); Sun, 18 Nov 2018 22:25:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=5OOEJLkkcCTFDbTI/SmsqZYlJ16emCYON0WRk2demfA=; b=s/aFuQ5rSjHQw0O5JWPb5JLvd9f+3ND119MA7sJHPXWysBc3ke+EzqhZJTLzeHSK/QakKG8fNYJN7ELB83j2wYMym52NhbGtaLjRSaV6Sz6tBEBaurR1HZBA30JmQDD40V2qHe/oH/WHIWeOkDzTro9lJ/oQP3Beo0S36sLbmQo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gOQV0-0001he-Km; Sun, 18 Nov 2018 18:04:42 +0100 Date: Sun, 18 Nov 2018 18:04:42 +0100 From: Andrew Lunn To: Martin Blumenstingl Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] net: phy: icplus: use the BIT macro where possible Message-ID: <20181118170442.GD5591@lunn.ch> References: <20181117182007.14791-1-martin.blumenstingl@googlemail.com> <20181117182007.14791-5-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181117182007.14791-5-martin.blumenstingl@googlemail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 17, 2018 at 07:20:04PM +0100, Martin Blumenstingl wrote: > This makes the code consistent by using the BIT() macro instead of > manual bit-shifting for some of the fields. No functional changes. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Andrew Lunn Andrew