Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs

Ming Lei
2018-11-19T08:15:36Z

On Thu, Nov 15, 2018 at 04:23:56PM -0800, Omar Sandoval wrote:
> On Thu, Nov 15, 2018 at 04:52:55PM +0800, Ming Lei wrote:
> > BTRFS is the only user of this helper, so move this helper into
> > BTRFS, and implement it via bio_for_each_segment_all(), since
> > bio->bi_vcnt may not equal to number of pages after multipage bvec
> > is enabled.
>
> Shouldn't you also get rid of bio_pages_all() in this patch?

Good catch!

thanks,
Ming