Re: [PATCH V10 15/19] block: always define BIO_MAX_PAGES as 256

Christoph Hellwig
2018-11-16T13:53:45Z

> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 5040e9a2eb09..277921ad42e7 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -34,15 +34,7 @@
> #define BIO_BUG_ON
> #endif
>
> -#ifdef CONFIG_THP_SWAP
> -#if HPAGE_PMD_NR > 256
> -#define BIO_MAX_PAGES HPAGE_PMD_NR
> -#else
> #define BIO_MAX_PAGES 256
> -#endif
> -#else
> -#define BIO_MAX_PAGES 256
> -#endif

Looks good. This mess should have never gone in.

Reviewed-by: Christoph Hellwig <hch@lst.de>