Re: [PATCH V10 12/19] block: allow bio_for_each_segment_all() to iterate over multi-page bvec

David Sterba
2018-11-15T12:43:17Z

On Thu, Nov 15, 2018 at 04:52:59PM +0800, Ming Lei wrote:
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index 13ba2011a306..789b09ae402a 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -123,6 +123,7 @@ static int blk_report_zones(struct gendisk *disk, sector_t sector,
> unsigned int z = 0, n, nrz = *nr_zones;
> sector_t capacity = get_capacity(disk);
> int ret;
> + struct bvec_iter_all iter_all;
>
> while (z < nrz && sector < capacity) {
> n = nrz - z;

iter_all is added but not used and I don't see any
bio_for_each_segment_all for conversion in this function.