From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>,
stable@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit()
Date: Mon, 19 Nov 2018 14:57:04 +0200 [thread overview]
Message-ID: <20181119125704.GC8755@linux.intel.com> (raw)
In-Reply-To: <20181118232157.GA1711@sasha-vm>
On Sun, Nov 18, 2018 at 06:21:57PM -0500, Sasha Levin wrote:
> There's no "preferred" approach really. I try to warn about cases like
> this early because the response rates to Greg's "FAILED" email seem to
> be low - by the time they are sent out people are done with that code
> and have moved on.
>
> In this scenario, for exmaple, this patch would not apply to any stable
> tree because it depends on a previous patch in this series that was not
> tagged for stable. My hopes are that if I warn you about this early you
> can work around this (for example, by marking that prior patch for
> stable as well) so you won't need to deal with this patch again in a few
> weeks.
>
> There's no need to change anything about your flow if it works for you.
Ok, I see. Yeah, it is just how I organize my work. Rather solve the
patch dependency sudoku one time than two times.
When I maintain a subsystem I've thought that it is my responsibility to
always do that and not wait someone else to do it for me :-) That is the
responsibility part of the equation when you have the power to decide
what gets in.
Right now I have two failed merges in my queue that I plan to take care
of them next week.
> Thanks,
> Sasha
/Jarkko
next prev parent reply other threads:[~2018-11-19 12:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 12:38 [PATCH v8 00/17] Removed nested TPM operations Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 01/17] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 02/17] tpm: fix invalid return value in pubek_show() Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 03/17] tpm: return 0 from pcrs_show() when tpm1_pcr_read() fails Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 04/17] tpm: print tpm2_commit_space() error inside tpm2_commit_space() Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 05/17] tpm: declare struct tpm_header Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 06/17] tpm: access command header through struct in tpm_try_transmit() Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 07/17] tpm: encapsulate tpm_dev_transmit() Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit() Jarkko Sakkinen
2018-11-16 16:19 ` Sasha Levin
2018-11-18 7:36 ` Jarkko Sakkinen
2018-11-18 23:21 ` Sasha Levin
2018-11-19 12:57 ` Jarkko Sakkinen [this message]
2018-11-16 12:38 ` [PATCH v8 09/17] tpm: clean up tpm_try_transmit() error handling flow Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 10/17] tpm: move tpm_validate_commmand() to tpm2-space.c Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 11/17] tpm: move TPM space code out of tpm_transmit() Jarkko Sakkinen
2018-11-16 17:06 ` Stefan Berger
2018-11-16 12:38 ` [PATCH v8 12/17] tpm: remove @space from tpm_transmit() Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 13/17] tpm: use tpm_try_get_ops() in tpm-sysfs.c Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop() Jarkko Sakkinen
2018-11-16 17:00 ` Stefan Berger
2018-11-16 12:38 ` [PATCH v8 16/17] tpm: take TPM chip power gating out of tpm_transmit() Jarkko Sakkinen
2018-11-16 17:02 ` Stefan Berger
2018-11-18 7:37 ` Jarkko Sakkinen
2018-11-16 12:38 ` [PATCH v8 17/17] tpm: remove @flags from tpm_transmit() Jarkko Sakkinen
2018-11-16 17:02 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119125704.GC8755@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tadeusz.struk@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).