From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D95C43441 for ; Mon, 19 Nov 2018 20:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A5FE20851 for ; Mon, 19 Nov 2018 20:22:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="I1oVR1gn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A5FE20851 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730750AbeKTGrc (ORCPT ); Tue, 20 Nov 2018 01:47:32 -0500 Received: from mail.skyhub.de ([5.9.137.197]:38132 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728938AbeKTGrc (ORCPT ); Tue, 20 Nov 2018 01:47:32 -0500 Received: from zn.tnic (p200300EC2BE2B700F95221CD056129B8.dip0.t-ipconnect.de [IPv6:2003:ec:2be2:b700:f952:21cd:561:29b8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 390591EC084D; Mon, 19 Nov 2018 21:22:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1542658934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4MqzI3FI4U69SGOzwTifB1i6/4kbnVwHK5DkvrCba4o=; b=I1oVR1gngnzX4hZ+hXjAMg57a2p5lbN99jjDQxJlyaBDaiEqhe6ZW6rg8v5ZgCme8yooNi m3d+ZEJnZTFDE3bolevXftEUNHOqBLvT0HEhi+1NhQn/oY3+0k6mEVDIdG7o0Wjbi89Gfo P8D2h2jsyS+/+twj/P4iMBwdKziphUc= Date: Mon, 19 Nov 2018 21:22:07 +0100 From: Borislav Petkov To: "Moger, Babu" Cc: Thomas Gleixner , "mingo@redhat.com" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "reinette.chatre@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v8 01/13] arch/resctrl: Start renaming the rdt files to more generic names Message-ID: <20181119202207.GK14688@zn.tnic> References: <20181116205407.10457-1-babu.moger@amd.com> <20181116205407.10457-2-babu.moger@amd.com> <20181118140735.GC19380@zn.tnic> <61f6e553-a72f-bfae-0887-44f066006118@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <61f6e553-a72f-bfae-0887-44f066006118@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 19, 2018 at 08:11:36PM +0000, Moger, Babu wrote: > Changed core.c and internel.h to res.c and res.h respectively. Both of > these files are about resource definitions and initialization. I guess but the core.c thing we do a lot in the kernel: $ git ls-files | grep -E "/core\.c" | wc -l 100 which denotes where the core functionality is located. res.c doesn't tell me that. res.h doesn't tell me either that it is an resctrl-internal header... IOW, calling it core.c and internal.h gives you an additional information what those files contain. And I think that's useful. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.