From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF2DC43441 for ; Mon, 19 Nov 2018 20:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E8ED2080C for ; Mon, 19 Nov 2018 20:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GW2YxQtx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E8ED2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730889AbeKTHQS (ORCPT ); Tue, 20 Nov 2018 02:16:18 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44292 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730797AbeKTHQS (ORCPT ); Tue, 20 Nov 2018 02:16:18 -0500 Received: by mail-pg1-f194.google.com with SMTP id t13so5692827pgr.11 for ; Mon, 19 Nov 2018 12:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RRrTLiFcYInOyf2eHFRPoMOlDE8FwjZkdLcBSDDzZ10=; b=GW2YxQtxcpxSTsjutLQpB7vygGEn9ghKRWwNSYZrRiPrpcikdPN3f4PYadyN/QDr2J zgFLI9CGYRJoZ7fdZwjpuA1Sl/+MkI0dIhYRgkzTEvl68NCSsmSTkzbGHTbffMXaVsTd wpUs+l5heI0gsHYlbqAvAraOMowk36O43DM80CvJQsJ3mJ/bUXfOfgDxH4P/dAbwr7Wb B2xzWEnrLRDCUE6fLpG+RApYsbb/wV/T43XyU/O+XLI5UfR9r4ubmdREN2NWp55PweGC yXUCyPhIPt22idUV3V8nrpWVDm8rQLsukEczCIvafhf84PYTh+hSGKbJRVlGtDahc6O4 srIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=RRrTLiFcYInOyf2eHFRPoMOlDE8FwjZkdLcBSDDzZ10=; b=TIFE8QghgKAuYTa2eiAn4E4CwF7GchzQwDJX+fYTIUwMSGafUJonu6ssyw3T/Pkc2q tptQlw0k8ekOEwhJWRNAOUrzjtb1Bwf4uR9b8Lr4C77zGnljMO1H04z1RFdJ0z0hrxl0 ZbBOtKl+lPMURcgCpS1K6DbzdpK5swB1pwoHTwufpWVnZhaIwhXT+wkI51+5fTH/GALH fGYFcrqs8Tm2fpFXJ7Ig/DxGjVR+T+sSxY7skdiH2h4nJQGEMF/LBNwFnwHou9gStIF5 Q0cvrArjeyUT66OaEUihHfvvCLO9tz6JSAHsfZwsRKrsjf4d5nWDelbs0ihU6eo9d1B2 dE/A== X-Gm-Message-State: AGRZ1gIqJ33D1tHKPMOk1rqD6IVpDMB4x0xSUqjgZQWbncFntZwIcfGL 0bfe45/PyAhqjfY/gaUoqOY= X-Google-Smtp-Source: AJdET5fOmeQDwjSL4aN4wDJkYGoYNGJjIXYCe+p4lo5AashulPz7ITnMpguU169smUaVjvEmwYKt+w== X-Received: by 2002:a62:6001:: with SMTP id u1-v6mr13376502pfb.130.1542660653259; Mon, 19 Nov 2018 12:50:53 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id l64sm45733854pge.73.2018.11.19.12.50.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 12:50:52 -0800 (PST) Date: Mon, 19 Nov 2018 12:50:50 -0800 From: Guenter Roeck To: Florian Fainelli Cc: arnd@arndb.de, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250 Message-ID: <20181119205050.GA1933@roeck-us.net> References: <20181115011125.GA32556@roeck-us.net> <29E7A6C0-7829-4650-93C6-7220FECAA6EF@gmail.com> <20181115053836.GA7606@roeck-us.net> <27ed27d3-220e-963f-7d2c-64df10421580@gmail.com> <20181115172535.GA26922@roeck-us.net> <5937b814-ca5f-5786-93a1-3334df8c92dc@gmail.com> <20181116011656.GA21813@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 19, 2018 at 10:44:30AM -0800, Florian Fainelli wrote: > On 11/15/18 5:16 PM, Guenter Roeck wrote: > > On Thu, Nov 15, 2018 at 11:48:20AM -0800, Florian Fainelli wrote: > >> > >> OK, would you mind testing this below? It seems to me that 8250_of.c is > >> incompatible with arch/powerpc/kernel/legacy_serial.c and that is what > >> is causing the issue here. > >> > >> diff --git a/drivers/tty/serial/8250/Kconfig > >> b/drivers/tty/serial/8250/Kconfig > >> index d7737dca0e48..21cb14cbd34a 100644 > >> --- a/drivers/tty/serial/8250/Kconfig > >> +++ b/drivers/tty/serial/8250/Kconfig > >> @@ -483,7 +483,7 @@ config SERIAL_8250_PXA > >> > >> config SERIAL_OF_PLATFORM > >> tristate "Devicetree based probing for 8250 ports" > >> - depends on SERIAL_8250 && OF > >> + depends on SERIAL_8250 && OF && !(PPC && PPC_UDBG_16550) > >> default SERIAL_8250 > >> help > >> This option is used for all 8250 compatible serial ports that > > > > 44x/virtex5_defconfig has both PPC_UDBG_16550 and SERIAL_OF_PLATFORM enabled > > and fails to boot (or display anything on the console) with this patch applied. > > Thanks for trying, can you either share or provide a link to the mpc85xx > and ml507 qemu command lines that you use? I spent a good chunk of my > time trying to get a kernel to boot but has failed so far. > Good to hear that this doesn't just happen to me ;-). The scripts are all at https://github.com/groeck/linux-build-test/. This includes root file systems. The one used below is at https://github.com/groeck/linux-build-test/blob/master/rootfs/ppc/rootfs.cpio.gz ml507: qemu-system-ppc -kernel vmlinux -M virtex-ml507 -m 256 -no-reboot \ -initrd rootfs.cpio -dtb arch/powerpc/boot/dts/virtex440-ml507.dtb \ --append 'rdinit=/sbin/init panic=-1 mem=256M console=ttyS0' \ -monitor none -nographic mpc85xx: qemu-system-ppc -kernel arch/powerpc/boot/uImage -M mpc8544ds -m 256 \ -no-reboot -initrd rootfs.cpio \ --append 'rdinit=/sbin/init panic=-1 mem=256M console=ttyS0' \ -monitor none -nographic Hope this helps, Guenter