From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FA0C43610 for ; Tue, 20 Nov 2018 05:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2751020685 for ; Tue, 20 Nov 2018 05:47:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="p4jGt7IN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2751020685 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732099AbeKTQOV (ORCPT ); Tue, 20 Nov 2018 11:14:21 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44722 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731740AbeKTQOV (ORCPT ); Tue, 20 Nov 2018 11:14:21 -0500 Received: by mail-wr1-f68.google.com with SMTP id j17-v6so556738wrq.11 for ; Mon, 19 Nov 2018 21:47:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7kzKPNIihbMNTWm722YEOBTDCnKQ7HDU6hQ3FTufTWI=; b=p4jGt7INtLEPr/p1p8diwE87M9R3HchNJm5APcR13NzZPqPDVtgyaddP8V3GB0/3fu 3sF4qXcP9GgsbhG5ZhN71cJPkooPvAP7ybTqAmn0j8U2IqoFYqpDdFkCTGu+gg0woHG5 K0JlLd9E/trUyXZitzS2X7siMaEPpEqFgbV8bX0R/kN/8Yza9eHbsJsAXf9yMZ7XS+cN cjrBBI0LVh157X56ICuGlR8Dvo6foBSC4REku87Pn3cv22T5V5ph5KQVVxacctP5G77K vvVmxEvm+xgAmn9UdYswBTztKQwHmjlPpbuSIb3Z59TTN+unI6NOKVOqI8dBk4VX42oZ bffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7kzKPNIihbMNTWm722YEOBTDCnKQ7HDU6hQ3FTufTWI=; b=M1uexGrSA9ps+aFeEVMaGY2S9wCZYqTLZy5yXiaCfkTeYDYlr50TOmScsYjc+5o5Zu fnPGdyim5cJPOaKxqMvQ6hsTrQIAA/BBvlp4w1opRQ0coba92eZHHiQ0jy6fepIwLrN4 jPgj0jQ/O85pnhff7GVGChV4jvWR/A63uc6G54ZCYeM7tG0LV2hgY8t2P1wTwyyfkWg8 qr2fvoYoFAKxEleW5X/bnQzJr/Hf19qVEj0jL5QNI8EbGb16Uj1ewRg4XBc8T9cvFXqv +F+XZCfE9ZFj44CVUb+HJYj3M+s7Vspq6zUEG0SYdMX5s/hPgEdEFoWdMt4zb7rCPHrX wbVA== X-Gm-Message-State: AA+aEWZLim9RKS8wllmcFs8sI++tcE20RWc/k4sv/Mdwf4NbXxzoUQSL psv3L9OZyRxEORvc3ah8ZOhEm7tmjGXtbQ== X-Google-Smtp-Source: AFSGD/V6xPD7CXrbWV67MGBanWNbQR910EchuZ3Rl5RHCTJxi4IOjT+ZW1MGO6JkgHnkXEDkCty1wQ== X-Received: by 2002:adf:f504:: with SMTP id q4mr554168wro.321.1542692822126; Mon, 19 Nov 2018 21:47:02 -0800 (PST) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id b18sm11022401wrw.83.2018.11.19.21.47.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 21:47:01 -0800 (PST) Date: Tue, 20 Nov 2018 06:46:59 +0100 From: LABBE Corentin To: Herbert Xu Cc: Ard Biesheuvel , "David S. Miller" , Eric Biggers , nhorman@tuxdriver.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux Kernel Mailing List Subject: Re: [PATCH v2 01/11] crypto: move crypto_alg_get/crypto_alg_put to linux/crypto.h Message-ID: <20181120054659.GA12679@Red> References: <1542657210-37739-1-git-send-email-clabbe@baylibre.com> <1542657210-37739-2-git-send-email-clabbe@baylibre.com> <20181120031047.diqgmbluclbbkhav@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181120031047.diqgmbluclbbkhav@gondor.apana.org.au> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 20, 2018 at 11:10:47AM +0800, Herbert Xu wrote: > On Mon, Nov 19, 2018 at 12:25:10PM -0800, Ard Biesheuvel wrote: > > On Mon, 19 Nov 2018 at 11:53, Corentin Labbe wrote: > > > > > > Since we will need crypto_alg_get/crypto_alg_put for "locking" > > > crypto_alg when updating stats, we need it to be via linux/crypto.h > > > > > > > This seems backwards to me. Surely, crypto stats are permitted to use > > the internal crypto API? > > I agree. > I dont understand what is backwards ? moving or using ? What do you suggest for "locking" crypto_alg ? Regards