* [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
@ 2018-11-20 13:18 Yangtao Li
2018-11-22 14:16 ` Daniel Lezcano
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Yangtao Li @ 2018-11-20 13:18 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel, Yangtao Li
use of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/clocksource/timer-integrator-ap.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/clocksource/timer-integrator-ap.c b/drivers/clocksource/timer-integrator-ap.c
index 76e526f58620..50e0a9166f66 100644
--- a/drivers/clocksource/timer-integrator-ap.c
+++ b/drivers/clocksource/timer-integrator-ap.c
@@ -204,8 +204,6 @@ static int __init integrator_ap_timer_init_of(struct device_node *node)
return err;
}
- pri_node = of_find_node_by_path(path);
-
err = of_property_read_string(of_aliases,
"arm,timer-secondary", &path);
if (err) {
@@ -213,14 +211,18 @@ static int __init integrator_ap_timer_init_of(struct device_node *node)
return err;
}
+ pri_node = of_find_node_by_path(path);
+ if (node == pri_node){
+ of_node_put(pri_node);
- sec_node = of_find_node_by_path(path);
-
- if (node == pri_node)
/* The primary timer lacks IRQ, use as clocksource */
return integrator_clocksource_init(rate, base);
+ }
+ sec_node = of_find_node_by_path(path);
if (node == sec_node) {
+ of_node_put(sec_node);
+
/* The secondary timer will drive the clock event */
irq = irq_of_parse_and_map(node, 0);
return integrator_clockevent_init(rate, base, irq);
--
2.17.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-20 13:18 [PATCH] clocksource/drivers/integrator-ap: add of_node_put() Yangtao Li
@ 2018-11-22 14:16 ` Daniel Lezcano
2018-11-22 14:22 ` Linus Walleij
2018-11-22 14:26 ` Daniel Lezcano
2 siblings, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2018-11-22 14:16 UTC (permalink / raw)
To: Yangtao Li, tglx; +Cc: linux-kernel, Linus Walleij
Hi Yangtao,
On 20/11/2018 14:18, Yangtao Li wrote:
> use of_node_put() to release the refcount.
In future please give a better description.
No need to resend, I'll do the change.
Linus? I'm about to take this patch. Is it fine for you?
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/clocksource/timer-integrator-ap.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clocksource/timer-integrator-ap.c b/drivers/clocksource/timer-integrator-ap.c
> index 76e526f58620..50e0a9166f66 100644
> --- a/drivers/clocksource/timer-integrator-ap.c
> +++ b/drivers/clocksource/timer-integrator-ap.c
> @@ -204,8 +204,6 @@ static int __init integrator_ap_timer_init_of(struct device_node *node)
> return err;
> }
>
> - pri_node = of_find_node_by_path(path);
> -
> err = of_property_read_string(of_aliases,
> "arm,timer-secondary", &path);
> if (err) {
> @@ -213,14 +211,18 @@ static int __init integrator_ap_timer_init_of(struct device_node *node)
> return err;
> }
>
> + pri_node = of_find_node_by_path(path);
> + if (node == pri_node){
> + of_node_put(pri_node);
>
> - sec_node = of_find_node_by_path(path);
> -
> - if (node == pri_node)
> /* The primary timer lacks IRQ, use as clocksource */
> return integrator_clocksource_init(rate, base);
> + }
>
> + sec_node = of_find_node_by_path(path);
> if (node == sec_node) {
> + of_node_put(sec_node);
> +
> /* The secondary timer will drive the clock event */
> irq = irq_of_parse_and_map(node, 0);
> return integrator_clockevent_init(rate, base, irq);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-20 13:18 [PATCH] clocksource/drivers/integrator-ap: add of_node_put() Yangtao Li
2018-11-22 14:16 ` Daniel Lezcano
@ 2018-11-22 14:22 ` Linus Walleij
2018-11-22 14:26 ` Daniel Lezcano
2018-11-22 14:26 ` Daniel Lezcano
2 siblings, 1 reply; 14+ messages in thread
From: Linus Walleij @ 2018-11-22 14:22 UTC (permalink / raw)
To: tiny.windzz; +Cc: Daniel Lezcano, Thomas Gleixner, linux-kernel@vger.kernel.org
On Tue, Nov 20, 2018 at 2:19 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
> use of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-20 13:18 [PATCH] clocksource/drivers/integrator-ap: add of_node_put() Yangtao Li
2018-11-22 14:16 ` Daniel Lezcano
2018-11-22 14:22 ` Linus Walleij
@ 2018-11-22 14:26 ` Daniel Lezcano
2018-11-22 14:33 ` Frank Lee
2 siblings, 1 reply; 14+ messages in thread
From: Daniel Lezcano @ 2018-11-22 14:26 UTC (permalink / raw)
To: Yangtao Li, tglx; +Cc: linux-kernel
On 20/11/2018 14:18, Yangtao Li wrote:
> use of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied, thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:26 ` Daniel Lezcano
@ 2018-11-22 14:33 ` Frank Lee
2018-11-22 14:36 ` Frank Lee
2018-11-22 14:37 ` Daniel Lezcano
0 siblings, 2 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-22 14:33 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: tglx, linux-kernel
On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 20/11/2018 14:18, Yangtao Li wrote:
> > use of_node_put() to release the refcount.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>
> Applied, thanks!
Hi Daniel：
This patch is a bit small, I will resend。
Thanks，
Yangtao
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:33 ` Frank Lee
@ 2018-11-22 14:36 ` Frank Lee
2018-11-22 14:37 ` Daniel Lezcano
1 sibling, 0 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-22 14:36 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: tglx, linux-kernel
On Thu, Nov 22, 2018 at 10:33 PM Frank Lee <tiny.windzz@gmail.com> wrote:
>
> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
> >
> > On 20/11/2018 14:18, Yangtao Li wrote:
> > > use of_node_put() to release the refcount.
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >
> > Applied, thanks!
> Hi Daniel：
>
> This patch is a bit small, I will resend。
Code logic seems to be a bit problem, sorry
--Yangtao
>
> Thanks，
> Yangtao
> >
> >
> > --
> > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> >
> > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> > <http://twitter.com/#!/linaroorg> Twitter |
> > <http://www.linaro.org/linaro-blog/> Blog
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:33 ` Frank Lee
2018-11-22 14:36 ` Frank Lee
@ 2018-11-22 14:37 ` Daniel Lezcano
2018-11-22 14:39 ` Frank Lee
1 sibling, 1 reply; 14+ messages in thread
From: Daniel Lezcano @ 2018-11-22 14:37 UTC (permalink / raw)
To: Frank Lee; +Cc: tglx, linux-kernel
On 22/11/2018 15:33, Frank Lee wrote:
> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 20/11/2018 14:18, Yangtao Li wrote:
>>> use of_node_put() to release the refcount.
>>>
>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>>
>> Applied, thanks!
> Hi Daniel：
>
> This patch is a bit small, I will resend。
What do you mean by 'small' ?
>> --
>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>> <http://twitter.com/#!/linaroorg> Twitter |
>> <http://www.linaro.org/linaro-blog/> Blog
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:37 ` Daniel Lezcano
@ 2018-11-22 14:39 ` Frank Lee
2018-11-22 14:41 ` Daniel Lezcano
2018-11-22 14:43 ` Daniel Lezcano
0 siblings, 2 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-22 14:39 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: tglx, linux-kernel
On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 22/11/2018 15:33, Frank Lee wrote:
> > On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 20/11/2018 14:18, Yangtao Li wrote:
> >>> use of_node_put() to release the refcount.
> >>>
> >>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >>
> >> Applied, thanks!
> > Hi Daniel：
> >
> > This patch is a bit small, I will resend。
>
> What do you mean by 'small' ?
pri_node = of_find_node_by_path(path);
if (node == pri_node){
of_node_put(pri_node);
/* The primary timer lacks IRQ, use as clocksource */
return integrator_clocksource_init(rate, base);
}
sec_node = of_find_node_by_path(path);
Under my revision, pri_node and sec_nodeare the same thing.
Yours,
Yangtao
>
> >> --
> >> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> >>
> >> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> >> <http://twitter.com/#!/linaroorg> Twitter |
> >> <http://www.linaro.org/linaro-blog/> Blog
> >>
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:39 ` Frank Lee
@ 2018-11-22 14:41 ` Daniel Lezcano
2018-11-22 14:43 ` Daniel Lezcano
1 sibling, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2018-11-22 14:41 UTC (permalink / raw)
To: Frank Lee; +Cc: tglx, linux-kernel
On 22/11/2018 15:39, Frank Lee wrote:
> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 22/11/2018 15:33, Frank Lee wrote:
>>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
>>> <daniel.lezcano@linaro.org> wrote:
>>>>
>>>> On 20/11/2018 14:18, Yangtao Li wrote:
>>>>> use of_node_put() to release the refcount.
>>>>>
>>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>>>>
>>>> Applied, thanks!
>>> Hi Daniel：
>>>
>>> This patch is a bit small, I will resend。
>>
>> What do you mean by 'small' ?
> pri_node = of_find_node_by_path(path);
> if (node == pri_node){
> of_node_put(pri_node);
>
> /* The primary timer lacks IRQ, use as clocksource */
> return integrator_clocksource_init(rate, base);
> }
>
> sec_node = of_find_node_by_path(path);
>
> Under my revision, pri_node and sec_nodeare the same thing.
>
> Yours,
> Yangtao
>>
>>>> --
>>>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>>>
>>>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>>>> <http://twitter.com/#!/linaroorg> Twitter |
>>>> <http://www.linaro.org/linaro-blog/> Blog
>>>>
>>
>>
>> --
>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>> <http://twitter.com/#!/linaroorg> Twitter |
>> <http://www.linaro.org/linaro-blog/> Blog
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:39 ` Frank Lee
2018-11-22 14:41 ` Daniel Lezcano
@ 2018-11-22 14:43 ` Daniel Lezcano
2018-11-22 14:48 ` Frank Lee
1 sibling, 1 reply; 14+ messages in thread
From: Daniel Lezcano @ 2018-11-22 14:43 UTC (permalink / raw)
To: Frank Lee; +Cc: tglx, linux-kernel
On 22/11/2018 15:39, Frank Lee wrote:
> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 22/11/2018 15:33, Frank Lee wrote:
>>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
>>> <daniel.lezcano@linaro.org> wrote:
>>>>
>>>> On 20/11/2018 14:18, Yangtao Li wrote:
>>>>> use of_node_put() to release the refcount.
>>>>>
>>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>>>>
>>>> Applied, thanks!
>>> Hi Daniel：
>>>
>>> This patch is a bit small, I will resend。
>>
>> What do you mean by 'small' ?
> pri_node = of_find_node_by_path(path);
> if (node == pri_node){
> of_node_put(pri_node);
>
> /* The primary timer lacks IRQ, use as clocksource */
> return integrator_clocksource_init(rate, base);
> }
>
> sec_node = of_find_node_by_path(path);
>
> Under my revision, pri_node and sec_nodeare the same thing.
Oh, right. Missed it :/
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:43 ` Daniel Lezcano
@ 2018-11-22 14:48 ` Frank Lee
2018-11-22 14:51 ` Daniel Lezcano
0 siblings, 1 reply; 14+ messages in thread
From: Frank Lee @ 2018-11-22 14:48 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: tglx, linux-kernel
On Thu, Nov 22, 2018 at 10:43 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 22/11/2018 15:39, Frank Lee wrote:
> > On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 22/11/2018 15:33, Frank Lee wrote:
> >>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> >>> <daniel.lezcano@linaro.org> wrote:
> >>>>
> >>>> On 20/11/2018 14:18, Yangtao Li wrote:
> >>>>> use of_node_put() to release the refcount.
> >>>>>
> >>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >>>>
> >>>> Applied, thanks!
> >>> Hi Daniel：
> >>>
> >>> This patch is a bit small, I will resend。
> >>
> >> What do you mean by 'small' ?
> > pri_node = of_find_node_by_path(path);
> > if (node == pri_node){
> > of_node_put(pri_node);
> >
> > /* The primary timer lacks IRQ, use as clocksource */
> > return integrator_clocksource_init(rate, base);
> > }
> >
> > sec_node = of_find_node_by_path(path);
> >
> > Under my revision, pri_node and sec_nodeare the same thing.
>
> Oh, right. Missed it :/
Daniel ,
Have you mde the patch merged?
Which git is the patch in?
I hope that you can revert it and I‘ll resend new one
or I'll resend patch based on the modify.
Yours,
Yangtao
>
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:48 ` Frank Lee
@ 2018-11-22 14:51 ` Daniel Lezcano
2018-11-22 14:52 ` Frank Lee
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Lezcano @ 2018-11-22 14:51 UTC (permalink / raw)
To: Frank Lee; +Cc: tglx, linux-kernel
On 22/11/2018 15:48, Frank Lee wrote:
> On Thu, Nov 22, 2018 at 10:43 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 22/11/2018 15:39, Frank Lee wrote:
>>> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
>>> <daniel.lezcano@linaro.org> wrote:
>>>>
>>>> On 22/11/2018 15:33, Frank Lee wrote:
>>>>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
>>>>> <daniel.lezcano@linaro.org> wrote:
>>>>>>
>>>>>> On 20/11/2018 14:18, Yangtao Li wrote:
>>>>>>> use of_node_put() to release the refcount.
>>>>>>>
>>>>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>>>>>>
>>>>>> Applied, thanks!
>>>>> Hi Daniel：
>>>>>
>>>>> This patch is a bit small, I will resend。
>>>>
>>>> What do you mean by 'small' ?
>>> pri_node = of_find_node_by_path(path);
>>> if (node == pri_node){
>>> of_node_put(pri_node);
>>>
>>> /* The primary timer lacks IRQ, use as clocksource */
>>> return integrator_clocksource_init(rate, base);
>>> }
>>>
>>> sec_node = of_find_node_by_path(path);
>>>
>>> Under my revision, pri_node and sec_nodeare the same thing.
>>
>> Oh, right. Missed it :/
> Daniel ,
>
> Have you mde the patch merged?
> Which git is the patch in?
> I hope that you can revert it and I‘ll resend new one
> or I'll resend patch based on the modify.
I can drop it, resend a new one.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
2018-11-22 14:51 ` Daniel Lezcano
@ 2018-11-22 14:52 ` Frank Lee
0 siblings, 0 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-22 14:52 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: tglx, linux-kernel
On Thu, Nov 22, 2018 at 10:51 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 22/11/2018 15:48, Frank Lee wrote:
> > On Thu, Nov 22, 2018 at 10:43 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 22/11/2018 15:39, Frank Lee wrote:
> >>> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
> >>> <daniel.lezcano@linaro.org> wrote:
> >>>>
> >>>> On 22/11/2018 15:33, Frank Lee wrote:
> >>>>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> >>>>> <daniel.lezcano@linaro.org> wrote:
> >>>>>>
> >>>>>> On 20/11/2018 14:18, Yangtao Li wrote:
> >>>>>>> use of_node_put() to release the refcount.
> >>>>>>>
> >>>>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >>>>>>
> >>>>>> Applied, thanks!
> >>>>> Hi Daniel：
> >>>>>
> >>>>> This patch is a bit small, I will resend。
> >>>>
> >>>> What do you mean by 'small' ?
> >>> pri_node = of_find_node_by_path(path);
> >>> if (node == pri_node){
> >>> of_node_put(pri_node);
> >>>
> >>> /* The primary timer lacks IRQ, use as clocksource */
> >>> return integrator_clocksource_init(rate, base);
> >>> }
> >>>
> >>> sec_node = of_find_node_by_path(path);
> >>>
> >>> Under my revision, pri_node and sec_nodeare the same thing.
> >>
> >> Oh, right. Missed it :/
> > Daniel ,
> >
> > Have you mde the patch merged?
> > Which git is the patch in?
> > I hope that you can revert it and I‘ll resend new one
> > or I'll resend patch based on the modify.
>
> I can drop it, resend a new one.
Thanks,
Yangtao
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-11-22 14:52 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 13:18 [PATCH] clocksource/drivers/integrator-ap: add of_node_put() Yangtao Li
2018-11-22 14:16 ` Daniel Lezcano
2018-11-22 14:22 ` Linus Walleij
2018-11-22 14:26 ` Daniel Lezcano
2018-11-22 14:26 ` Daniel Lezcano
2018-11-22 14:33 ` Frank Lee
2018-11-22 14:36 ` Frank Lee
2018-11-22 14:37 ` Daniel Lezcano
2018-11-22 14:39 ` Frank Lee
2018-11-22 14:41 ` Daniel Lezcano
2018-11-22 14:43 ` Daniel Lezcano
2018-11-22 14:48 ` Frank Lee
2018-11-22 14:51 ` Daniel Lezcano
2018-11-22 14:52 ` Frank Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox