Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

Frank Lee
2018-11-22T14:52:25Z

On Thu, Nov 22, 2018 at 10:51 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 22/11/2018 15:48, Frank Lee wrote:
> > On Thu, Nov 22, 2018 at 10:43 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 22/11/2018 15:39, Frank Lee wrote:
> >>> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
> >>> <daniel.lezcano@linaro.org> wrote:
> >>>>
> >>>> On 22/11/2018 15:33, Frank Lee wrote:
> >>>>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> >>>>> <daniel.lezcano@linaro.org> wrote:
> >>>>>>
> >>>>>> On 20/11/2018 14:18, Yangtao Li wrote:
> >>>>>>> use of_node_put() to release the refcount.
> >>>>>>>
> >>>>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >>>>>>
> >>>>>> Applied, thanks!
> >>>>> Hi Daniel：
> >>>>>
> >>>>> This patch is a bit small, I will resend。
> >>>>
> >>>> What do you mean by 'small' ?
> >>> pri_node = of_find_node_by_path(path);
> >>> if (node == pri_node){
> >>> of_node_put(pri_node);
> >>>
> >>> /* The primary timer lacks IRQ, use as clocksource */
> >>> return integrator_clocksource_init(rate, base);
> >>> }
> >>>
> >>> sec_node = of_find_node_by_path(path);
> >>>
> >>> Under my revision, pri_node and sec_nodeare the same thing.
> >>
> >> Oh, right. Missed it :/
> > Daniel ,
> >
> > Have you mde the patch merged?
> > Which git is the patch in?
> > I hope that you can revert it and I‘ll resend new one
> > or I'll resend patch based on the modify.
>
> I can drop it, resend a new one.
Thanks,
Yangtao
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>