From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC076C32788 for ; Tue, 20 Nov 2018 15:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD071208E3 for ; Tue, 20 Nov 2018 15:32:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD071208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730138AbeKUCCJ (ORCPT ); Tue, 20 Nov 2018 21:02:09 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:50173 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbeKUCCJ (ORCPT ); Tue, 20 Nov 2018 21:02:09 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wAKFTWsK005364; Tue, 20 Nov 2018 09:32:18 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail1.cirrus.com (mail1.cirrus.com [141.131.3.20]) by mx0b-001ae601.pphosted.com with ESMTP id 2ntg9sv8js-1; Tue, 20 Nov 2018 09:32:17 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail1.cirrus.com (Postfix) with ESMTP id 2E940611E126; Tue, 20 Nov 2018 09:32:17 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Tue, 20 Nov 2018 15:32:16 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wAKFWFsk019092; Tue, 20 Nov 2018 15:32:16 GMT Date: Tue, 20 Nov 2018 15:32:15 +0000 From: Charles Keepax To: Marek Szyprowski CC: Mark Brown , Linus Walleij , Lee Jones , Liam Girdwood , , Subject: Re: Applied "regulator: wm8994: Pass descriptor instead of GPIO number" to the regulator tree Message-ID: <20181120153215.GC16508@imbe.wolfsonmicro.main> References: <20180517164120.485F844007E@finisterre.ee.mobilebroadband> <66d3b74c-0152-b17b-89d4-a21d33445b25@samsung.com> <20181120144700.GB16508@imbe.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=521 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811200138 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 20, 2018 at 03:58:59PM +0100, Marek Szyprowski wrote: > Hi Charles, > > On 2018-11-20 15:47, Charles Keepax wrote: > > On Tue, Nov 20, 2018 at 02:43:32PM +0100, Marek Szyprowski wrote: > >> On 2018-05-17 18:41, Mark Brown wrote: > >>> Subject: [PATCH] regulator: wm8994: Pass descriptor instead of GPIO number > >> This patch causes following kernel warning on Samsung Exynos4412 based > >> Trats2 board: > >> > >> wm8994 4-001a: Failed to get supply 'DBVDD1': -517 > >> wm8994 4-001a: Failed to get supplies: -517 > > How is the wm8994 being registered on this board? I am having > > difficulty finding a device tree or a board file that relates to > > the board and includes the wm8994. > > > Please check arch/arm/boot/dts/exynos4412-trats2.dts details. The I2C device > is defined in exynos4412-midas.dtsi, it uses "wlf,wm1811" compatible. > Ok got it, thanks. > > >>> @@ -203,6 +203,18 @@ static const struct i2c_board_info wm1277_devs[] = { > >>> { I2C_BOARD_INFO("wm8958", 0x1a), /* WM8958 is the superset */ > >>> .platform_data = &wm8994_pdata, > >>> .irq = GLENFARCLAS_PMIC_IRQ_BASE + WM831X_IRQ_GPIO_2, > >>> + .dev_name = "wm8958", > >>> + }, > >>> +}; > >>> + > >>> +static struct gpiod_lookup_table wm8994_gpiod_table = { > >>> + .dev_id = "i2c-wm8958", /* I2C device name */ > >>> + .table = { > >>> + GPIO_LOOKUP("GPION", 6, > >>> + "wlf,ldo1ena", GPIO_ACTIVE_HIGH), > >>> + GPIO_LOOKUP("GPION", 4, > >>> + "wlf,ldo2ena", GPIO_ACTIVE_HIGH), > >>> + { }, > >>> }, > >>> }; > > If its being done through a board file I guess you will need the > > equivalent of this. > > > No board file, everything in DT. > This is really weird, because the error in your log relates to DBVDD1 which is an independent regulator supplied by a separate regulator. I am really having some difficulty seeing how the patch interfers. It is definitely that patch which causes the issue, like you revert it and things work again? Thanks, Charles