From: Tejun Heo <tj@kernel.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: "open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
kernel-team@fb.com
Subject: Re: [PATCH for-4.20-fixes] cgroup: fix CSS_TASK_ITER_PROCS
Date: Tue, 20 Nov 2018 08:13:19 -0800 [thread overview]
Message-ID: <20181120161319.GR2509588@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20181108201515.GC2509588@devbig004.ftw2.facebook.com>
On Thu, Nov 08, 2018 at 12:15:15PM -0800, Tejun Heo wrote:
> CSS_TASK_ITER_PROCS implements process-only iteration by making
> css_task_iter_advance() skip tasks which aren't threadgroup leaders;
> however, when an iteration is started css_task_iter_start() calls the
> inner helper function css_task_iter_advance_css_set() instead of
> css_task_iter_advance(). As the helper doesn't have the skip logic,
> when the first task to visit is a non-leader thread, it doesn't get
> skipped correctly as shown in the following example.
Applied to cgroup/for-4.20-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2018-11-20 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 19:46 Cgroups v2 bug: incorrect reporting in "domain threaded" cgroup.procs file Michael Kerrisk (man-pages)
2018-11-08 20:15 ` [PATCH for-4.20-fixes] cgroup: fix CSS_TASK_ITER_PROCS Tejun Heo
2018-11-20 16:13 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120161319.GR2509588@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox