Re: [PATCH v3 2/4] bus: fsl-mc: add fsl-mc userspace support

gregkh
2018-11-20T16:44:21Z

On Tue, Nov 20, 2018 at 03:39:45PM +0000, Ioana Ciornei wrote:
> +
> + error = fsl_mc_uapi_create_device_file(mc_bus);
> + if (error < 0) {
> + error = -EPROBE_DEFER;
> + goto error_cleanup_msi_domain;
> + }

What error could occur here that would be somehow fixed if you defer and
try this all again? Shouldn't you just return the error given (as
something really went wrong here, it's not a "something else needs to
start up first issue), and abort?

thanks,

greg k-h