RE: [PATCH 4.19 00/42] 4.19.4-stable review

David Laight
2018-11-23T15:44:29Z

From: Thomas Voegtle
> Sent: 23 November 2018 15:41
> On Fri, 23 Nov 2018, Greg Kroah-Hartman wrote:
>
> > On Thu, Nov 22, 2018 at 09:53:35PM +0100, Thomas Voegtle wrote:
> >>
> >> Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
> >>
> >> CALL scripts/checksyscalls.sh
> >> DESCEND objtool
> >> CHK include/generated/compile.h
> >> CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o
> >> drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’:
> >> drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects
> >> argument of type ‘long long unsigned int’, but argument 5 has type ‘long
> >> unsigned int’ [-Werror=format=]
> >> seq_printf(m, "\t\t(%03d, %04d) %08llx: ",
> >> ~~~~~^
> >> %08lx
> >> cc1: all warnings being treated as errors
> >
> > Warnings treated as errors? That's rough, sorry, don't do that :)
>
> I had CONFIG_DRM_I915_WERROR=y for whatever reason.
> The whole thing confused me a lot.
> Sorry.

Well, if you compile that code for a 32bit architecture it is likely
to print garbage.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)