From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
"Herton R. Krzesinski" <herton@redhat.com>
Subject: Re: [PATCHv2 01/10] tools lib traceevent: Use LDFLAGS in the build commands
Date: Thu, 22 Nov 2018 10:30:06 +0100 [thread overview]
Message-ID: <20181122093006.GD15953@krava> (raw)
In-Reply-To: <20181116130158.GA30583@krava>
On Fri, Nov 16, 2018 at 02:01:58PM +0100, Jiri Olsa wrote:
> On Wed, Oct 17, 2018 at 10:23:41AM -0400, Steven Rostedt wrote:
> > On Tue, 16 Oct 2018 17:45:26 +0200
> > Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > > On Tue, Oct 16, 2018 at 11:21:36AM -0400, Steven Rostedt wrote:
> > > > On Tue, 16 Oct 2018 17:06:06 +0200
> > > > Jiri Olsa <jolsa@kernel.org> wrote:
> > > >
> > > > > So user could specify outside LDFLAGS values.
> > > > >
> > > > > Cc: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> > > > > Cc: Steven Rostedt <rostedt@goodmis.org>
> > > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > > > ---
> > > > > tools/lib/traceevent/Makefile | 4 ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> > > > > index 0b4e833088a4..e535073c94ce 100644
> > > > > --- a/tools/lib/traceevent/Makefile
> > > > > +++ b/tools/lib/traceevent/Makefile
> > > > > @@ -174,7 +174,7 @@ $(TE_IN): force
> > > > > $(Q)$(MAKE) $(build)=libtraceevent
> > > > >
> > > > > $(OUTPUT)libtraceevent.so.$(EVENT_PARSE_VERSION): $(TE_IN)
> > > > > - $(QUIET_LINK)$(CC) --shared $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
> > > > > + $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
> > > > > @ln -sf $(@F) $(OUTPUT)libtraceevent.so
> > > > > @ln -sf $(@F) $(OUTPUT)libtraceevent.so.$(EP_VERSION)
> > > > >
> > > > > @@ -193,7 +193,7 @@ $(PLUGINS_IN): force
> > > > > $(Q)$(MAKE) $(build)=$(plugin_obj)
> > > > >
> > > > > $(OUTPUT)%.so: $(OUTPUT)%-in.o
> > > > > - $(QUIET_LINK)$(CC) $(CFLAGS) -shared -nostartfiles -o $@ $^
> > > > > + $(QUIET_LINK)$(CC) -shared $(LDFLAGS) -nostartfiles -o $@ $^
> > > >
> > > >
> > > > I'm guessing that the CFLAGS are not needed here, but shouldn't that
> > > > also be mentioned in the change log?
> > >
> > > yep, sry.. v2 attached
> > >
> >
> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Arnaldo,
> could you pull in this one?
ping, thanks
jirka
next prev parent reply other threads:[~2018-11-22 9:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 15:06 [PATCH 00/10] tools: Various build flags fixes Jiri Olsa
2018-10-16 15:06 ` [PATCH 01/10] tools lib traceevent: Use LDFLAGS in the build commands Jiri Olsa
2018-10-16 15:21 ` Steven Rostedt
2018-10-16 15:45 ` [PATCHv2 " Jiri Olsa
2018-10-17 14:23 ` Steven Rostedt
2018-11-16 13:01 ` Jiri Olsa
2018-11-22 9:30 ` Jiri Olsa [this message]
2018-11-26 18:40 ` Arnaldo Carvalho de Melo
2018-11-28 13:56 ` Arnaldo Carvalho de Melo
2018-12-12 9:12 ` [PATCHv3 " Jiri Olsa
2018-12-12 12:41 ` Arnaldo Carvalho de Melo
2018-12-20 18:07 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-10-16 15:06 ` [PATCH 02/10] tools perf: Pass build flags to traceevent build Jiri Olsa
2018-10-18 6:20 ` [tip:perf/urgent] perf tools: " tip-bot for Jiri Olsa
2018-10-30 9:25 ` [PATCH 02/10] tools perf: " Jiri Olsa
2018-10-16 15:06 ` [PATCH 03/10] tools cpupower debug: Allow to use outside build flags Jiri Olsa
2018-10-16 15:06 ` [PATCH 04/10] tools cpupower: Override CFLAGS assignments Jiri Olsa
2018-10-16 15:06 ` [PATCH 05/10] tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 06/10] tools thermal tmon: Override CFLAGS assignments Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 07/10] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
2018-10-16 15:06 ` [PATCH 08/10] tools power turbostat: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 09/10] tools iio: Override CFLAGS assignments Jiri Olsa
2018-10-21 12:26 ` Jonathan Cameron
2018-10-22 8:53 ` Jiri Olsa
2018-10-17 13:23 ` [PATCH 00/10] tools: Various build flags fixes Thomas Renninger
2018-10-17 15:28 ` Shuah Khan
2018-10-22 8:51 ` Jiri Olsa
2018-10-23 15:17 ` Shuah Khan
2018-10-23 16:53 ` Shuah Khan
2018-10-23 17:21 ` Jiri Olsa
2018-10-22 14:50 ` [PATCH 10/10] tools gpio: Override CFLAGS assignments Jiri Olsa
2018-10-30 9:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122093006.GD15953@krava \
--to=jolsa@redhat.com \
--cc=herton@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox