Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

Takashi Iwai
2018-11-20T09:23:29Z

On Tue, 20 Nov 2018 10:10:39 +0100,
Pavel Machek wrote:
>
> On Tue 2018-11-20 08:07:09, Takashi Iwai wrote:
> > On Tue, 20 Nov 2018 00:57:13 +0100,
> > Pavel Machek wrote:
> > >
> > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
> > > > +#include <linux/platform_data/x86/huawei_wmi.h>
> > > > +
> > > > +static int (*huawei_wmi_micmute_led_set_func)(bool);
> > > > +
> > >
> > > So we should not be doing this.
> > >
> > > Thinkpad ACPI module exports its LEDs there, for example.
> >
> > Both thinkpad_acpi and dell_laptop provide the interface to HD-audio
> > in the very same way like this.
>
> Not good :-(. Please don't add new ones, general purpose LEDs should
> really use LED subsystem.

What's the problem with this approach?

Takashi