From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5E3C43441 for ; Fri, 23 Nov 2018 00:06:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F62B20820 for ; Fri, 23 Nov 2018 00:06:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="OZ9/A3tO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F62B20820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407934AbeKWKsi (ORCPT ); Fri, 23 Nov 2018 05:48:38 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:42578 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729489AbeKWKsi (ORCPT ); Fri, 23 Nov 2018 05:48:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IMakWGmyQF2R+OfH1u3XFfFnrC1OqupFsKwM1SiQ9wg=; b=OZ9/A3tOq09wamNOzZtsz+QIn 2mtJFoxKdRifqTa2X3ys7HjHjhVwjXbWjjPntbb8ge1SA/AskK6z45zpvRlGRkh3bYlAp2zJOt3Yp Zoa12AEfOa/WF+PrY6x2SNBuYTg4ENEwPBXsZzEsNulNMyatsLLe5xzibJnJNg3WtuKrY=; Received: from n2100.armlinux.org.uk ([fd8f:7570:feb6:1:214:fdff:fe10:4f86]:40515) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1gPyzc-0004on-Iy; Fri, 23 Nov 2018 00:06:44 +0000 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.90_1) (envelope-from ) id 1gPyzZ-0007ny-Vi; Fri, 23 Nov 2018 00:06:42 +0000 Date: Fri, 23 Nov 2018 00:06:40 +0000 From: Russell King - ARM Linux To: Sasha Levin Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.4 3/8] ARM: make lookup_processor_type() non-__init Message-ID: <20181123000640.GP30658@n2100.armlinux.org.uk> References: <20181122195716.13961-1-sashal@kernel.org> <20181122195716.13961-3-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181122195716.13961-3-sashal@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Same comments as for the 4.9 version of these patches, and also applies to the two 3.18 patches as well. They aren't fixes, but preparation for fixes, and should not be backported without the actual Spectre fix patch (which probably requires manual backport effort.) On Thu, Nov 22, 2018 at 02:57:10PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary startup code during hotplug. > > Reviewed-by: Julien Thierry > Signed-off-by: Russell King > Signed-off-by: Sasha Levin > --- > arch/arm/kernel/head-common.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S > index 8733012d231f..7e662bdd5cb3 100644 > --- a/arch/arm/kernel/head-common.S > +++ b/arch/arm/kernel/head-common.S > @@ -122,6 +122,9 @@ __mmap_switched_data: > .long init_thread_union + THREAD_START_SP @ sp > .size __mmap_switched_data, . - __mmap_switched_data > > + __FINIT > + .text > + > /* > * This provides a C-API version of __lookup_processor_type > */ > @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type) > ldmfd sp!, {r4 - r6, r9, pc} > ENDPROC(lookup_processor_type) > > - __FINIT > - .text > - > /* > * Read processor ID register (CP#15, CR0), and look up in the linker-built > * supported processor list. Note that we can't use the absolute addresses > -- > 2.17.1 > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up