From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB26FC43441 for ; Fri, 23 Nov 2018 08:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA82D20861 for ; Fri, 23 Nov 2018 08:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA82D20861 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408480AbeKWTBt (ORCPT ); Fri, 23 Nov 2018 14:01:49 -0500 Received: from mail.bootlin.com ([62.4.15.54]:47940 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731828AbeKWTBt (ORCPT ); Fri, 23 Nov 2018 14:01:49 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 0ED2920D29; Fri, 23 Nov 2018 09:18:37 +0100 (CET) Received: from localhost (aaubervilliers-681-1-94-205.w90-88.abo.wanadoo.fr [90.88.35.205]) by mail.bootlin.com (Postfix) with ESMTPSA id D190A20726; Fri, 23 Nov 2018 09:18:26 +0100 (CET) Date: Fri, 23 Nov 2018 09:18:22 +0100 From: Antoine Tenart To: Miquel Raynal Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Antoine Tenart Subject: Re: [PATCH] phy: mvebu-cp110-comphy: fix spelling in structure name Message-ID: <20181123081822.GA24654@kwain> References: <20181122201909.5235-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181122201909.5235-1-miquel.raynal@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On Thu, Nov 22, 2018 at 09:19:09PM +0100, Miquel Raynal wrote: > Rename the mvebu_comhy_conf structure to be mvebu_comphy_conf, which is > probably what the original author meant. > > Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver") Could you drop the Fixes tag and send it again? The patch is not fixing any bug within the driver. > Signed-off-by: Miquel Raynal > --- > > Sorry for such a trivial patch. As I used this driver as a base for > another comphy driver (Armada 3700, coming soon) I spot this mistake > but I would understand if you ignore the patch! It's improving the readability of the code, so it's useful :) Thanks! Antoine > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c > index 86a5f7b9448b..31b9a1c18345 100644 > --- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c > +++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c > @@ -114,7 +114,7 @@ > #define MVEBU_COMPHY_LANES 6 > #define MVEBU_COMPHY_PORTS 3 > > -struct mvebu_comhy_conf { > +struct mvebu_comphy_conf { > enum phy_mode mode; > unsigned lane; > unsigned port; > @@ -129,7 +129,7 @@ struct mvebu_comhy_conf { > .mux = _mux, \ > } > > -static const struct mvebu_comhy_conf mvebu_comphy_cp110_modes[] = { > +static const struct mvebu_comphy_conf mvebu_comphy_cp110_modes[] = { > /* lane 0 */ > MVEBU_COMPHY_CONF(0, 1, PHY_MODE_SGMII, 0x1), > MVEBU_COMPHY_CONF(0, 1, PHY_MODE_2500SGMII, 0x1), > -- > 2.19.1 > -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com