Re: [PATCH] phy: mvebu-cp110-comphy: fix spelling in structure name

Antoine Tenart
2018-11-23T08:18:40Z

Hi Miquel,

On Thu, Nov 22, 2018 at 09:19:09PM +0100, Miquel Raynal wrote:
> Rename the mvebu_comhy_conf structure to be mvebu_comphy_conf, which is
> probably what the original author meant.
>
> Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver")

Could you drop the Fixes tag and send it again? The patch is not fixing
any bug within the driver.

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Sorry for such a trivial patch. As I used this driver as a base for
> another comphy driver (Armada 3700, coming soon) I spot this mistake
> but I would understand if you ignore the patch!

It's improving the readability of the code, so it's useful :)

Thanks!
Antoine

> drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c
> index 86a5f7b9448b..31b9a1c18345 100644
> --- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c
> +++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c
> @@ -114,7 +114,7 @@
> #define MVEBU_COMPHY_LANES 6
> #define MVEBU_COMPHY_PORTS 3
>
> -struct mvebu_comhy_conf {
> +struct mvebu_comphy_conf {
> enum phy_mode mode;
> unsigned lane;
> unsigned port;
> @@ -129,7 +129,7 @@ struct mvebu_comhy_conf {
> .mux = _mux, \
> }
>
> -static const struct mvebu_comhy_conf mvebu_comphy_cp110_modes[] = {
> +static const struct mvebu_comphy_conf mvebu_comphy_cp110_modes[] = {
> /* lane 0 */
> MVEBU_COMPHY_CONF(0, 1, PHY_MODE_SGMII, 0x1),
> MVEBU_COMPHY_CONF(0, 1, PHY_MODE_2500SGMII, 0x1),
> --
> 2.19.1
>

--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering