Re: [PATCH v9 10/13] x86/resctrl: Fix the messages in rdt_last_cmd_printf and rdt_last_cmd_puts

Borislav Petkov
2018-11-26T22:28:04Z

On Mon, Nov 26, 2018 at 02:16:24PM -0800, Reinette Chatre wrote:
> Hi Babu and Borislav,
>
> Two typos seemed to have slipped through into the merged commit ...
>
> On 11/21/2018 12:28 PM, Moger, Babu wrote:
> > @@ -163,14 +163,14 @@ int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r,
> > * either is exclusive.
> > */
> > if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, true)) {
> > - rdt_last_cmd_printf("overlaps with exclusive group\n");
> > + rdt_last_cmd_printf("Overlaps with exclusive group\n");
> > return -EINVAL;
> > }
> >
> > if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, false)) {
> > if (rdtgrp->mode == RDT_MODE_EXCLUSIVE ||
> > rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) {
> > - rdt_last_cmd_printf("overlaps with other group\n");
> > + rdt_last_cmd_printf("0verlaps with other group\n");
> > return -EINVAL;
> > }
> > }
>
> There is a zero instead of O used in second "Overlaps".

LOL!

That's so l337 :-)

> > @@ -1235,7 +1235,7 @@ static ssize_t rdtgroup_mode_write(struct kernfs_open_file *of,
> > goto out;
> > rdtgrp->mode = RDT_MODE_PSEUDO_LOCKSETUP;
> > } else {
> > - rdt_last_cmd_printf("unknown/unsupported mode\n");
> > + rdt_last_cmd_printf("Unknown orunsupported mode\n");
> > ret = -EINVAL;
> > }
>
> Missing a space.

Whoops, nice catch. Can you send a fix pls?

Thx.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.