Re: [PATCH v2 02/43] drm/sun4i: frontend: Replace ARGB with XRGB as supported format

Maxime Ripard
2018-11-27T08:31:37Z

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On Fri, Nov 23, 2018 at 10:24:34AM +0100, Paul Kocialkowski wrote:
> The frontend documentation (for the A33) mentions that ARGB is supported
> as output, but with the alpha component always set to 0xff. In practice,
> this means that the alpha component cannot be preserved when going
> through the frontend. Since the information is lost, ARGB is not
> properly supported.
>
> As a result, expose the matching format supported by the frontend (both
> for input and output) as XRGB instead of ARGB.
>
> Since ARGB was the selected format for connecting the frontend to the
> backend, change it to XRGB to reflect this as well.
>
> The A31 and A80 SoCs apparently have a bit to enable proper alpha,
> but this is not supported at this point (see the comment already in the
> code).
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]