* [PATCH] drop silly "static inline asmlinkage" from dump_stack()
@ 2018-11-24 9:35 Alexey Dobriyan
2018-12-02 7:33 ` Joey Pabalinas
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2018-11-24 9:35 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/printk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl)
{
}
-static inline asmlinkage void dump_stack(void)
+static inline void dump_stack(void)
{
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()
2018-11-24 9:35 [PATCH] drop silly "static inline asmlinkage" from dump_stack() Alexey Dobriyan
@ 2018-12-02 7:33 ` Joey Pabalinas
2018-12-02 9:02 ` Alexey Dobriyan
0 siblings, 1 reply; 4+ messages in thread
From: Joey Pabalinas @ 2018-12-02 7:33 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: akpm, linux-kernel, Joey Pabalinas
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Sat, Nov 24, 2018 at 12:35:30PM +0300, Alexey Dobriyan wrote:
> -static inline asmlinkage void dump_stack(void)
> +static inline void dump_stack(void)
Why is it "silly"? An explanation in the commit message would be useful.
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> include/linux/printk.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl)
> {
> }
>
> -static inline asmlinkage void dump_stack(void)
> +static inline void dump_stack(void)
> {
> }
>
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()
2018-12-02 7:33 ` Joey Pabalinas
@ 2018-12-02 9:02 ` Alexey Dobriyan
2018-12-02 9:51 ` Joey Pabalinas
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2018-12-02 9:02 UTC (permalink / raw)
To: Joey Pabalinas, akpm, linux-kernel
On Sat, Dec 01, 2018 at 09:33:38PM -1000, Joey Pabalinas wrote:
> On Sat, Nov 24, 2018 at 12:35:30PM +0300, Alexey Dobriyan wrote:
> > -static inline asmlinkage void dump_stack(void)
> > +static inline void dump_stack(void)
>
> Why is it "silly"? An explanation in the commit message would be useful.
Empty function will be inlined so asmlinkage doesn't do anything.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()
2018-12-02 9:02 ` Alexey Dobriyan
@ 2018-12-02 9:51 ` Joey Pabalinas
0 siblings, 0 replies; 4+ messages in thread
From: Joey Pabalinas @ 2018-12-02 9:51 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Joey Pabalinas, akpm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
On Sun, Dec 02, 2018 at 12:02:54PM +0300, Alexey Dobriyan wrote:
> Empty function will be inlined so asmlinkage doesn't do anything.
Yes, that is an example of a perfect explanation to have in the
commit message :) Ack from me after that addition.
Acked-by: Joey Pabalinas <joeypabalinas@gmail.com>
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-02 9:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-24 9:35 [PATCH] drop silly "static inline asmlinkage" from dump_stack() Alexey Dobriyan
2018-12-02 7:33 ` Joey Pabalinas
2018-12-02 9:02 ` Alexey Dobriyan
2018-12-02 9:51 ` Joey Pabalinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox