Re: [PATCH] locking/atomics: build atomic headers as required

Peter Zijlstra
2018-11-26T09:33:57Z

On Mon, Nov 26, 2018 at 09:04:48AM +0000, Mark Rutland wrote:
> On Mon, Nov 26, 2018 at 09:46:21AM +0100, Peter Zijlstra wrote:
> > On Fri, Nov 23, 2018 at 03:33:21PM +0000, Mark Rutland wrote:
> > > Andrew and Ingo report that the check-atomics.sh script is simply too
> > > slow to run for every kernel build, and it's impractical to make it
> > > faster without rewriting it in something other than shell.
> > >
> > > Rather than committing the generated headers, let's regenerate these
> > > as-required for a pristine tree.
> >
> > Thing is, I '_never_' have a pristine tree. Now, I would also be in a
> > position to know if something with the atomics changed, but that can't help
> > other people that never use pristine trees.
>
> Just to be clear, regardless of whether the tree is pristine, the headers will
> be rebuilt iff their dependencies have changed. It's just that they
> *definitely* have to be built for a pristine tree.
>
> So perhaps I just need to clarify the commit message? Or do you envisage a
> problem with that?
>
> I've realised I missed the fallbacks and library script from the dependency
> list, so I can also fix that for v2.

Ah, ok. Yeah, maybe call that out explicitly. But that will certainly
work for me.

Thanks!