From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] i3c: fix an error code in i3c_master_add_i3c_dev_locked()
Date: Mon, 26 Nov 2018 09:46:34 +0100 [thread overview]
Message-ID: <20181126094634.6166a238@bbrezillon> (raw)
In-Reply-To: <20181123071324.iwmbay2yrbiocisf@kili.mountain>
On Fri, 23 Nov 2018 10:14:42 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should return "ret" as-is. The "newdev" variable is a valid pointer.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued to i3c/next.
Thanks,
Boris
> ---
> drivers/i3c/master.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 0ea7bb045fad..bda4b9613e53 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1823,10 +1823,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
> return PTR_ERR(newdev);
>
> ret = i3c_master_attach_i3c_dev(master, newdev);
> - if (ret) {
> - ret = PTR_ERR(newdev);
> + if (ret)
> goto err_free_dev;
> - }
>
> ret = i3c_master_retrieve_dev_info(newdev);
> if (ret)
prev parent reply other threads:[~2018-11-26 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 7:14 [PATCH 1/2] i3c: fix an error code in i3c_master_add_i3c_dev_locked() Dan Carpenter
2018-11-26 8:46 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126094634.6166a238@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox