From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C3DC43441 for ; Mon, 26 Nov 2018 12:57:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D164220862 for ; Mon, 26 Nov 2018 12:57:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D164220862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbeKZXvD (ORCPT ); Mon, 26 Nov 2018 18:51:03 -0500 Received: from mga01.intel.com ([192.55.52.88]:44422 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbeKZXvD (ORCPT ); Mon, 26 Nov 2018 18:51:03 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2018 04:56:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,282,1539673200"; d="scan'208";a="276948380" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga005.jf.intel.com with ESMTP; 26 Nov 2018 04:56:57 -0800 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1gRGRc-000195-4v; Mon, 26 Nov 2018 14:56:56 +0200 Date: Mon, 26 Nov 2018 14:56:56 +0200 From: Andy Shevchenko To: Heikki Krogerus Cc: "Rafael J. Wysocki" , Mika Westerberg , Rob Herring , Frank Rowand , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/3] device property: Introduce fwnode_get_name() Message-ID: <20181126125656.GF10650@smile.fi.intel.com> References: <20181126114752.69597-1-heikki.krogerus@linux.intel.com> <20181126114752.69597-2-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126114752.69597-2-heikki.krogerus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 26, 2018 at 02:47:50PM +0300, Heikki Krogerus wrote: > This helper returns the name of the node. The name is > primarily expected to be returned from a new fwnode > operation meant for this purpose, but when no name is > returned, the helper will also attempt to read a device > property "name". > +int fwnode_get_name(const struct fwnode_handle *fwnode, char *buf, size_t len) > +{ > + const char *name; > + int ret; > + > + if (!fwnode_call_int_op(fwnode, get_name, buf, len)) > + return 0; > + > + ret = fwnode_call_int_op(fwnode, property_read_string_array, > + "name", &name, 1); > + if (!ret) > + snprintf(buf, len, "%s", name); What are we going to do in case snprintf has found no room for entire string? > + > + return ret; > +} -- With Best Regards, Andy Shevchenko