From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Joey Pabalinas <joeypabalinas@gmail.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v2 5/7] zram: support idle/huge page writeback
Date: Mon, 26 Nov 2018 03:44:38 -1000 [thread overview]
Message-ID: <20181126134438.7shen7saoo2mifmo@gmail.com> (raw)
In-Reply-To: <20181126094737.sfudpeoigra2vir7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote:
> > + if ((mode & IDLE_WRITEBACK &&
> > + !zram_test_flag(zram, index, ZRAM_IDLE)) &&
> > + (mode & HUGE_WRITEBACK &&
> > + !zram_test_flag(zram, index, ZRAM_HUGE)))
> > + goto next;
>
> Wouldn't writing this as `mode & (IDLE_WRITEBACK | HUGE_WRITEBACK)`
> be a bit easier to read as well as slightly more compact?
Scratch this comment, it just dawned on me that this is not an
equivalent expression, heh.
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-26 13:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 8:28 [PATCH v2 0/7] zram idle page writeback Minchan Kim
2018-11-26 8:28 ` [PATCH v2 1/7] zram: fix lockdep warning of free block handling Minchan Kim
2018-11-26 20:49 ` Andrew Morton
2018-11-27 2:05 ` Minchan Kim
2018-11-26 8:28 ` [PATCH v2 2/7] zram: fix double free backing device Minchan Kim
2018-11-26 8:28 ` [PATCH v2 3/7] zram: refactoring flags and writeback stuff Minchan Kim
2018-11-26 8:28 ` [PATCH v2 4/7] zram: introduce ZRAM_IDLE flag Minchan Kim
2018-11-26 8:28 ` [PATCH v2 5/7] zram: support idle/huge page writeback Minchan Kim
2018-11-26 9:47 ` Joey Pabalinas
2018-11-26 13:44 ` Joey Pabalinas [this message]
2018-11-27 2:13 ` Minchan Kim
2018-11-27 2:53 ` Joey Pabalinas
2018-11-26 8:28 ` [PATCH v2 6/7] zram: add bd_stat statistics Minchan Kim
2018-11-26 20:58 ` Andrew Morton
2018-11-27 2:07 ` Minchan Kim
2018-11-28 23:30 ` Andrew Morton
2018-11-29 1:45 ` Minchan Kim
2018-11-26 8:28 ` [PATCH v2 7/7] zram: writeback throttle Minchan Kim
2018-11-26 20:54 ` Andrew Morton
2018-11-27 2:08 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126134438.7shen7saoo2mifmo@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox