From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test: Fix perf_event_attr test failure
Date: Mon, 26 Nov 2018 17:07:02 -0300 [thread overview]
Message-ID: <20181126200702.GI18491@kernel.org> (raw)
In-Reply-To: <20181122140456.16817-1-adrian.hunter@intel.com>
Em Thu, Nov 22, 2018 at 04:04:56PM +0200, Adrian Hunter escreveu:
> Fix inconsistent use of tabs and spaces error:
Thanks, applied.
- Arnaldo
> # perf test 16 -v
> 16: Setup struct perf_event_attr :
> --- start ---
> test child forked, pid 20224
> File "/usr/libexec/perf-core/tests/attr.py", line 119
> log.warning("expected %s=%s, got %s" % (t, self[t], other[t]))
> ^
> TabError: inconsistent use of tabs and spaces in indentation
> test child finished with -1
> ---- end ----
> Setup struct perf_event_attr: FAILED!
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/tests/attr.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/attr.py b/tools/perf/tests/attr.py
> index ff9b60b99f52..44090a9a19f3 100644
> --- a/tools/perf/tests/attr.py
> +++ b/tools/perf/tests/attr.py
> @@ -116,7 +116,7 @@ class Event(dict):
> if not self.has_key(t) or not other.has_key(t):
> continue
> if not data_equal(self[t], other[t]):
> - log.warning("expected %s=%s, got %s" % (t, self[t], other[t]))
> + log.warning("expected %s=%s, got %s" % (t, self[t], other[t]))
>
> # Test file description needs to have following sections:
> # [config]
> --
> 2.17.1
--
- Arnaldo
next prev parent reply other threads:[~2018-11-27 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 14:04 [PATCH] perf test: Fix perf_event_attr test failure Adrian Hunter
2018-11-26 20:07 ` Arnaldo Carvalho de Melo [this message]
2018-12-14 20:25 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-12-18 13:52 ` tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126200702.GI18491@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox