From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F3EC43441 for ; Tue, 27 Nov 2018 08:54:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE14E208E7 for ; Tue, 27 Nov 2018 08:54:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qo63maKJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE14E208E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729883AbeK0TwB (ORCPT ); Tue, 27 Nov 2018 14:52:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:57274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729563AbeK0TwB (ORCPT ); Tue, 27 Nov 2018 14:52:01 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2BA7208E4; Tue, 27 Nov 2018 08:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543308890; bh=tFHsZr2m0JHbpM+HpS03ERcR9hd/kTlyfOH3hsMouyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qo63maKJ28GVPCKKiYvkHPFAaHZ8Np8EorexnG0x/n5hZSGEQqqzl+RR3mGdJsG/D g6UnqoBLVuf8ZSle4A15cxz0axfPbI+VNs2GZIBGk5kYdGp4PpfAB+Ftu5YqDGQDaP 8227LgfVN9L0zHUnU64GueSZtDcBc48AO4WToJ2g= Date: Tue, 27 Nov 2018 09:54:48 +0100 From: Greg KH To: Rodolfo Giometti Cc: YueHaibing , davem@davemloft.net, richardcochran@gmail.com, sudipm.mukherjee@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails Message-ID: <20181127085448.GA29599@kroah.com> References: <20181126102422.24028-1-yuehaibing@huawei.com> <44edc27b-e679-24e8-aef1-fe5b7570f982@enneenne.com> <20181127073410.GA13965@kroah.com> <53ba0e4e-5848-e6cb-4abf-39db292ba7f3@enneenne.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53ba0e4e-5848-e6cb-4abf-39db292ba7f3@enneenne.com> User-Agent: Mutt/1.11.0 (2018-11-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 27, 2018 at 09:36:38AM +0100, Rodolfo Giometti wrote: > On 27/11/2018 08:34, Greg KH wrote: > > On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: > > > On 26/11/2018 11:24, YueHaibing wrote: > > > > pps_register_source() has keeps error codes in a local variable, > > > > but it does not make use of the code. This patch let it return > > > > the errcode in case of failure. > > > > > > > > Suggested-by: Richard Cochran > > > > Signed-off-by: YueHaibing > > > > > > Acked-by: Rodolfo Giometti > > > > You are the maintainer of this file, shouldn't you be the one sending it > > off to Linus or putting it in your tree somewhere? > > This subsystem never had an official tree and in the past I simply acked the > code and patches was taken by you (or other maintainers) for inclusion... I > know it's not usual by it worked as is since right now! > > However if you prefer having an official tree even for LinuxPPS I can do it > and then sending my pull requests to Linus! Just let me know what is better > for you! :-) Ok, I'll take it now, thanks. greg k-h