Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()

Schrempf Frieder
2018-11-28T14:55:50Z

Hi Boris,

On 28.11.18 15:41, Boris Brezillon wrote:
> On Tue, 27 Nov 2018 07:44:52 +0000
> Schrempf Frieder <frieder.schrempf@kontron.de> wrote:
>
>> Fix the size of the buffer allocated to store the in-memory BBT.
>> This bug was previously hidden by a different bug, that was fixed in
>> d098093ba06e.
>>
>> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND devices")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> Looks like your From header does not match the SoB tag
> ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
> that. I'll fix it when applying, but maybe you should fix
> your .gitconfig to make them match.

Actually the From header in my local patch is correct (<first name>
<last name>, Frieder Schrempf) as it comes from my git config. But since
our company was renamed and our mail servers were transferred, our
e-mails are sent with From=<last name> <first name>.

It seems like git send-email or patchwork or whatever uses the
information from the e-mail header instead of what is in the patch.

I will try to raise this issue with our IT department as this would be
best fixed on their side.

Thanks,
Frieder

>
>> ---
>> drivers/mtd/nand/bbt.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
>> index 56cde38..c12497f 100644
>> --- a/drivers/mtd/nand/bbt.c
>> +++ b/drivers/mtd/nand/bbt.c
>> @@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
>> unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
>> BITS_PER_LONG);
>>
>> - nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
>> + nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
>> + GFP_KERNEL);
>> if (!nand->bbt.cache)
>> return -ENOMEM;
>>
>