From: Jessica Yu <jeyu@kernel.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: remove some duplicated includes
Date: Tue, 27 Nov 2018 13:00:02 +0100 [thread overview]
Message-ID: <20181127120002.GA17708@linux-8ccs> (raw)
In-Reply-To: <20181126142116.31090-1-tiny.windzz@gmail.com>
+++ Yangtao Li [26/11/18 09:21 -0500]:
>We include elf.h twice in module.c. It's unnecessary.
>hence just remove them.
>
>Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>---
> kernel/module.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index 49a405891587..438641fc4096 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -28,7 +28,6 @@
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
>-#include <linux/elf.h>
> #include <linux/proc_fs.h>
> #include <linux/security.h>
> #include <linux/seq_file.h>
elf.h is not _directly_ included twice in module.c, although it is
included by other header files that module.c pulls in. I'd rather keep
things as-is, since we shouldn't depend on other header files to pull
in the headers we want. I think it's better to keep the explicit
dependence/inclusion of elf.h in module.c.
Thanks,
Jessica
prev parent reply other threads:[~2018-11-27 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 14:21 [PATCH] module: remove some duplicated includes Yangtao Li
2018-11-27 12:00 ` Jessica Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127120002.GA17708@linux-8ccs \
--to=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox