Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular

Paul Gortmaker
2018-11-28T22:13:06Z

[Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On 28/11/2018 (Wed 19:22) Laurent Pinchart wrote:

> Hi Paul,
>
> On Wednesday, 28 November 2018 17:32:05 EET Paul Gortmaker wrote:
> > [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On
> 28/11/2018 (Wed 12:50) Robin Murphy wrote:
> > > On 26/11/2018 22:31, Paul Gortmaker wrote:
> > [...]
> >
> > >> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> > >> index 9e2655f1c1bf..de39ef992d8a 100644
> > >> --- a/drivers/iommu/ipmmu-vmsa.c
> > >> +++ b/drivers/iommu/ipmmu-vmsa.c
> > >> @@ -1,6 +1,8 @@
> > >>
> > >> // SPDX-License-Identifier: GPL-2.0
> > >> /*
> > >> * IPMMU VMSA
> > >
> > > Nit: this line doesn't convey any information that the module description
> > > below doesn't also say far more clearly, so you may as well just replace
> > > it entirely.
> >
> > No problem. Will do in v2.
>
> With that change, the blank line after MODULE_DEVICE_TABLE() removed, and
> <linux/init.h> moved to keep alphabetical order sorting of the includes,
> please add
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Updated and review tag added for v2.

Paul.
--

>
> to v2. Thank you for the patch.
>
> > > >+ * IOMMU API for Renesas VMSA-compatible IPMMU
> > > >+ * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > [...]
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>