From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB0FC43441 for ; Tue, 27 Nov 2018 18:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD8982082F for ; Tue, 27 Nov 2018 18:07:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD8982082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732145AbeK1FFs (ORCPT ); Wed, 28 Nov 2018 00:05:48 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44586 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbeK1FFs (ORCPT ); Wed, 28 Nov 2018 00:05:48 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A1E1A2379; Tue, 27 Nov 2018 10:07:05 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 70C293F575; Tue, 27 Nov 2018 10:07:05 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 4B3E21AE0A0D; Tue, 27 Nov 2018 18:07:23 +0000 (GMT) Date: Tue, 27 Nov 2018 18:07:23 +0000 From: Will Deacon To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , linux-arch@vger.kernel.org, Joel Fernandes , Masami Hiramatsu , Josh Poimboeuf , Andy Lutomirski , Frederic Weisbecker , Catalin Marinas , linux-arm-kernel@lists.infradead.org, stable@kernel.org Subject: Re: [for-next][PATCH 04/18] arm64: function_graph: Simplify with function_graph_entry() Message-ID: <20181127180722.GB19216@arm.com> References: <20181122002801.501220343@goodmis.org> <20181122003331.917870132@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181122003331.917870132@goodmis.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21, 2018 at 07:28:05PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The function_graph_entry() function does the work of calling the function > graph hook function and the management of the shadow stack, simplifying the > work done in the architecture dependent prepare_ftrace_return(). > > Have arm64 use the new code, and remove the shadow stack management as well as > having to set up the trace structure. > > This is needed to prepare for a fix of a design bug on how the curr_ret_stack > is used. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: stable@kernel.org > Fixes: 03274a3ffb449 ("tracing/fgraph: Adjust fgraph depth before calling trace return callback") > Signed-off-by: Steven Rostedt (VMware) > --- > arch/arm64/kernel/ftrace.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) Minor nit: the subject refers to function_graph_entry(), but looks like you settled on function_graph_enter() in the end. Anyway, looks like no change for us, so: Acked-by: Will Deacon Will