From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Allison Henderson <allison.henderson@oracle.com>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
martin.petersen@oracle.com, shirley.ma@oracle.com,
bob.liu@oracle.com
Subject: Re: [RFC PATCH v1 0/7] Block/XFS: Support alternative mirror device retry
Date: Tue, 27 Nov 2018 23:37:22 -0800 [thread overview]
Message-ID: <20181128073722.GB7084@infradead.org> (raw)
In-Reply-To: <20181128053303.GL6311@dastard>
On Wed, Nov 28, 2018 at 04:33:03PM +1100, Dave Chinner wrote:
> One thing that is going to make this more complex at the XFS layer
> is discontiguous buffers. They require multiple IOs (and therefore
> bios) and so we are going to need to ensure that all the bios use
> the same bi_rw_hint.
Well, in case of raid 1 the load balancing code might actually
map different bios to different initial legs. What we really need
is to keep the 'index' or each bio. One good way to archive that
is to just reuse the bio for the retry instead of allocating a new one.
next prev parent reply other threads:[~2018-11-28 7:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 3:49 [RFC PATCH v1 0/7] Block/XFS: Support alternative mirror device retry Allison Henderson
2018-11-28 3:49 ` [PATCH v1 1/7] block: add nr_mirrors to request_queue Allison Henderson
2018-11-28 3:49 ` [PATCH v1 2/7] block: expand write_hint of bio/request to rw_hint Allison Henderson
2018-11-28 3:49 ` [PATCH v1 3/7] md: raid1: handle bi_rw_hint accordingly Allison Henderson
2018-11-28 3:49 ` [PATCH v1 4/7] xfs: Add b_rw_hint to xfs_buf Allison Henderson
2018-11-28 5:03 ` Dave Chinner
2018-11-28 3:49 ` [PATCH v1 5/7] xfs: Add device retry Allison Henderson
2018-11-28 5:08 ` Dave Chinner
2018-11-28 5:22 ` Darrick J. Wong
2018-11-28 5:38 ` Dave Chinner
2018-11-28 7:35 ` Christoph Hellwig
2018-11-28 12:41 ` Bob Liu
2018-11-28 16:47 ` Allison Henderson
2018-11-28 3:49 ` [PATCH v1 6/7] xfs: Rewrite retried read Allison Henderson
2018-11-28 5:17 ` Dave Chinner
2018-11-28 5:26 ` Darrick J. Wong
2018-11-28 5:40 ` Dave Chinner
2018-11-28 3:49 ` [PATCH v1 7/7] xfs: Add tracepoints and logging to alternate device retry Allison Henderson
2018-11-28 5:33 ` [RFC PATCH v1 0/7] Block/XFS: Support alternative mirror " Dave Chinner
2018-11-28 5:49 ` Darrick J. Wong
2018-11-28 6:30 ` Dave Chinner
2018-11-28 7:15 ` Darrick J. Wong
2018-11-28 19:38 ` Andreas Dilger
2018-11-28 7:37 ` Christoph Hellwig [this message]
2018-11-28 7:46 ` Dave Chinner
2018-11-28 7:51 ` Christoph Hellwig
2018-11-28 7:45 ` Christoph Hellwig
2018-12-08 14:49 ` Bob Liu
2018-12-10 4:30 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128073722.GB7084@infradead.org \
--to=hch@infradead.org \
--cc=allison.henderson@oracle.com \
--cc=bob.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shirley.ma@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).