From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 00/10] Regulator ena_gpiod fixups
Date: Wed, 28 Nov 2018 15:22:38 +0000 [thread overview]
Message-ID: <20181128152238.GV16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181128104350.31902-1-linus.walleij@linaro.org>
On Wed, Nov 28, 2018 at 11:43:40AM +0100, Linus Walleij wrote:
> drivers/gpio/gpiolib.h | 6 -----
> drivers/regulator/da9211-regulator.c | 4 +--
> drivers/regulator/fixed.c | 4 ++-
> drivers/regulator/lm363x-regulator.c | 8 ++++--
> drivers/regulator/lp8788-ldo.c | 4 ++-
> drivers/regulator/max77686-regulator.c | 3 +--
> drivers/regulator/max8952.c | 8 +++---
> drivers/regulator/max8973-regulator.c | 12 ++++++---
> drivers/regulator/s5m8767.c | 37 ++++++++++++++++++--------
> drivers/regulator/tps65090-regulator.c | 10 +++----
> include/linux/gpio/consumer.h | 13 +++++++++
> 11 files changed, 72 insertions(+), 37 deletions(-)
It looks like the patches are assuming the regulator core,
doesn't free the GPIO on an error, however that is not true in
all cases. If only a single regulator has requested the GPIO then
all the error paths after the call to regulator_ena_gpio_request
in regulator_register will free the GPIO. Although this is not the
case if more than one regulator has requested the GPIO.
Thanks,
charles
next prev parent reply other threads:[~2018-11-28 15:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 10:43 [PATCH 00/10] Regulator ena_gpiod fixups Linus Walleij
2018-11-28 10:43 ` [PATCH 01/10] regulator: fixed: Let core handle GPIO descriptor Linus Walleij
2018-11-28 10:43 ` [PATCH 02/10] regulator: lm363x: " Linus Walleij
2018-11-28 10:43 ` [PATCH 03/10] regulator: lp8788-ldo: " Linus Walleij
2018-11-28 10:43 ` [PATCH 04/10] regulator: max8952: " Linus Walleij
2018-11-28 10:43 ` [PATCH 05/10] regulator: max8973: " Linus Walleij
2018-11-28 10:43 ` [PATCH 06/10] gpio: Export gpiod_get_from_of_node() Linus Walleij
2018-11-28 10:43 ` [PATCH 07/10] regulator: da9211: Let core handle GPIO descriptors Linus Walleij
2018-11-28 15:11 ` Charles Keepax
2018-11-28 10:43 ` [PATCH 08/10] regulator: max77686: Let core handle GPIO descriptor Linus Walleij
2018-11-28 15:24 ` Charles Keepax
2018-11-30 9:07 ` Linus Walleij
2018-11-28 10:43 ` [PATCH 09/10] regulator: s5m8767: Let core handle GPIO descriptors Linus Walleij
2018-11-28 15:17 ` Charles Keepax
2018-11-28 10:43 ` [PATCH 10/10] regulator: tps65090: " Linus Walleij
2018-11-28 15:18 ` Charles Keepax
2018-11-28 15:22 ` Charles Keepax [this message]
2018-11-29 15:52 ` [PATCH 00/10] Regulator ena_gpiod fixups Linus Walleij
2018-11-29 16:29 ` Mark Brown
2018-11-29 18:38 ` Bartosz Golaszewski
2018-11-29 19:01 ` Mark Brown
2018-11-30 8:35 ` Bartosz Golaszewski
2018-11-30 10:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128152238.GV16508@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox