* [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"
@ 2018-11-28 16:12 Colin King
2018-11-28 16:16 ` Samuel Thibault
2019-03-02 19:42 ` Samuel Thibault
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2018-11-28 16:12 UTC (permalink / raw)
To: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake in array speakup_default_msgs at index
MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index cea8707653f5..ee240d36f947 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -336,7 +336,7 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
[MSG_FUNCNAME_SPELL_DELAY_DEC] = "spell delay decrement",
[MSG_FUNCNAME_SPELL_DELAY_INC] = "spell delay increment",
[MSG_FUNCNAME_SPELL_WORD] = "spell word",
- [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
+ [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",
[MSG_FUNCNAME_TONE_DEC] = "tone decrement",
[MSG_FUNCNAME_TONE_INC] = "tone increment",
[MSG_FUNCNAME_VOICE_DEC] = "voice decrement",
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"
2018-11-28 16:12 [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically" Colin King
@ 2018-11-28 16:16 ` Samuel Thibault
2019-03-02 19:42 ` Samuel Thibault
1 sibling, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2018-11-28 16:16 UTC (permalink / raw)
To: Colin King
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Greg Kroah-Hartman,
speakup, devel, kernel-janitors, linux-kernel
Hello,
Colin King, le mer. 28 nov. 2018 16:12:32 +0000, a ecrit:
> - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
> + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",
Mmm, clearly an english typo. Speakup people, do you think there might
be any downside here? Could it be that it was done on purpose for e.g.
syntheses to pronounce it right?
Samuel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"
2018-11-28 16:12 [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically" Colin King
2018-11-28 16:16 ` Samuel Thibault
@ 2019-03-02 19:42 ` Samuel Thibault
2019-03-02 21:27 ` Christopher Brannon
1 sibling, 1 reply; 4+ messages in thread
From: Samuel Thibault @ 2019-03-02 19:42 UTC (permalink / raw)
To: Colin King
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Greg Kroah-Hartman,
speakup, devel, kernel-janitors, linux-kernel
Hello,
Colin King, le mer. 28 nov. 2018 16:12:32 +0000, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in array speakup_default_msgs at index
> MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
We never got any feedback from the speakup mailing list, I guess fixing
the typo is fine.
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/i18n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index cea8707653f5..ee240d36f947 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -336,7 +336,7 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
> [MSG_FUNCNAME_SPELL_DELAY_DEC] = "spell delay decrement",
> [MSG_FUNCNAME_SPELL_DELAY_INC] = "spell delay increment",
> [MSG_FUNCNAME_SPELL_WORD] = "spell word",
> - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
> + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",
> [MSG_FUNCNAME_TONE_DEC] = "tone decrement",
> [MSG_FUNCNAME_TONE_INC] = "tone increment",
> [MSG_FUNCNAME_VOICE_DEC] = "voice decrement",
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"
2019-03-02 19:42 ` Samuel Thibault
@ 2019-03-02 21:27 ` Christopher Brannon
0 siblings, 0 replies; 4+ messages in thread
From: Christopher Brannon @ 2019-03-02 21:27 UTC (permalink / raw)
To: Samuel Thibault
Cc: Colin King, William Hubbs, Chris Brannon, Kirk Reiser,
Greg Kroah-Hartman, speakup, devel, kernel-janitors, linux-kernel
Samuel Thibault writes:
> Hello,
>
> Colin King, le mer. 28 nov. 2018 16:12:32 +0000, a ecrit:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is a spelling mistake in array speakup_default_msgs at index
> > MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> We never got any feedback from the speakup mailing list, I guess fixing
> the typo is fine.
I'm sure there were deliberate mis-spellings in Speakup error
messages to accomodate pronunciation issues with older synths, but I
have no idea whether this is one of them. It's probably fine either way.
-- Chris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-02 21:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-28 16:12 [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically" Colin King
2018-11-28 16:16 ` Samuel Thibault
2019-03-02 19:42 ` Samuel Thibault
2019-03-02 21:27 ` Christopher Brannon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox