From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=3.0 tests=DKIM_ADSP_ALL,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DF7C43441 for ; Thu, 29 Nov 2018 00:27:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A44AE206B2 for ; Thu, 29 Nov 2018 00:27:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aussec.com header.i=@aussec.com header.b="GYeq+ruh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A44AE206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=aussec.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbeK2Lac (ORCPT ); Thu, 29 Nov 2018 06:30:32 -0500 Received: from csm1.csm-office.com.au ([165.228.118.109]:41382 "EHLO sleepy.aussec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726668AbeK2Lac (ORCPT ); Thu, 29 Nov 2018 06:30:32 -0500 X-Virus-Scanned: amavisd-new at aussec.com Received: from hpdv6.aussec.com.com (c110-21-61-29.farfl4.nsw.optusnet.com.au [110.21.61.29]) (authenticated bits=0) by sleepy.aussec.com (8.15.2/8.15.2) with ESMTPSA id wAT0QZ3R025194 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 29 Nov 2018 11:26:55 +1100 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aussec.com; s=2016; t=1543451215; bh=XAzu4O8ujMbP04ePHe2TGZD2glGDqDP4mjaTCDWGL8w=; h=From:To:Cc:Subject:Date; b=GYeq+ruhfWe1u0zCwGnk2QXcY0FdqQ/Nxseg/zBM+LKC5uAmIwLNXoPLHrDVIlQkK yymhgjtAUbVGCs1nOslj59m0e8Srre/ldgXggcRvxZnCsCX60J9wBDLlVaT2l6Dk55 tilysfmIzbuqev6pW0goqNWVqsiUHqBEbwfN6expV9NQW2sokE8gOyxCn3HflW5g8z 6jfEwYt21nLGF9n8DG2twfc/onlwtYU/OcUMo2PZvo1/DgeTwi7H0q344A3mHDMzHb C69zKU20ojqDzHD0NPlwjhYBs7IRthGtvXLfE3Jh3kB2lUEnwSKFQwIdSscgD0nFPy D/0Se7DDI4gMQ== From: Tom Burkart To: Linux kernel mailing list Cc: Tom Burkart Subject: [PATCH v11 0/3] PPS: pps-gpio PPS ECHO implementation Date: Thu, 29 Nov 2018 11:26:23 +1100 Message-Id: <20181129002626.5410-1-tom@aussec.com> X-Mailer: git-send-email 2.12.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, please find attached the PPS-GPIO PPS ECHO implementation patch. The driver claims to have echo functionality in the sysfs interface but this functionality is not present. This patch provides this functionality. Part 1 of the patch change the original driver from the number based GPIO ABI to the descriptor based ABI. Parts 2 and 3 then add the PPS ECHO functionality. This is enabled if a "echo-gpios" entry is found in the devicetree. Changes in v8: Changes requested by Rob Herring and Philipp Zabel: DT explanation and don't change the DT entry for the PPS gpio. Changes in v9: Simplify "if" expression by doing echo_active_ms validation earlier. Changes in v10: Changes requested by Philipp Zabel: Mostly cosmetic changes: PATCH 2/4 now reviewed. Thanks a lot, Philipp! (Please note that as of v11 PATCH 1 is gone so this has become PATCH 1) Changes in v11: Changes requested by Rob Herring: All changes in regard to the capture-clear DT entry are gone. On the linuxpps mailing list it was suggested to use a hrtimer for resetting the GPIO ECHO active state to the inactive state. Please also comment on whether a hrtimer is necessary/desirable for the purpose of resetting the echo pin active state. I am happy to implement it if this is useful/desirable. Please install, test and comment as it is now a quite major change to the driver. Suggestions for improvement are welcome. Tom Burkart Tom Burkart (3): pps: descriptor-based gpio dt-bindings: pps: pps-gpio PPS ECHO implementation pps: pps-gpio pps-echo implementation Documentation/devicetree/bindings/pps/pps-gpio.txt | 9 ++ drivers/pps/clients/pps-gpio.c | 167 ++++++++++++++++----- include/linux/pps-gpio.h | 6 +- 3 files changed, 142 insertions(+), 40 deletions(-) -- 2.12.3