Re: [PATCH v4 2/6] perf/core: Use ioctl to communicate driver configuration to kernel

Greg KH
2018-11-29T07:48:23Z

On Wed, Nov 28, 2018 at 03:01:14PM -0700, Mathieu Poirier wrote:
> This patch adds the mechanic needed for user space to send PMU specific
> configuration to the kernel driver using an ioctl() command. That way
> events can keep track of options that don't fit in the perf_event_attr
> structure like the selection of a CoreSight sink to use for the session.

This is what configfs is for, please use that instead of a generic "send
a string to the kernel for it to parse" type of thing. No other driver
does this (or if they do, they should not), so this driver should not do
it as well, sorry.

greg k-h