Re: [PATCH] scsi: libsas: Add missing license and update to SPDX license identifier

John Garry
2018-11-29T12:18:51Z

On 29/11/2018 12:13, Greg KH wrote:
>>> ...
>>> > >
>>> > > MODULE_AUTHOR("Luben Tuikov <luben_tuikov@adaptec.com>");
>>> > > MODULE_DESCRIPTION("SAS Transport Layer");
>>> > > MODULE_LICENSE("GPL v2");
>>> > >
>>> > > So the license specifies v2+ but module license states v2.
>>> > >
>>> > > I could not find a docment for guidance on this. I also note that making
>>> > > sas_task.c v2 would mean mixing v2 and v2+ into the module.
>> >
>> > This is not the only file in the kernel with this problem.
>> >
>> > For now, we have been trusting the "written text" lines over the
>> > MODULE_LICENSE() lines, as that seems to be the proper way forward.
>> >
>>> > > I did find an example of someone changing the license:
>>> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/i2c/busses/i2c-designware-slave.c?h=v4.20-rc4&id=15c566fcff9cc7b8fd64461d6ee6fd1bc665b444
>>> > >
>> >
>> > Yup, not good, that should be fixed.
> I take it back, the changelog for the patch explains what is happening
> here, the people involved were paying attention.
>

OK, but these sample patches were just some I selected at random. May be
many more (incorrect)...

Cheers,
John

> greg k-h
>
> .
>