Re: [PATCH] scsi: libsas: Add missing license and update to SPDX license identifier

Greg KH
2018-11-27T14:43:38Z

On Tue, Nov 27, 2018 at 10:15:32PM +0800, John Garry wrote:
> Currently sas_task.c has no license specifier, so add SPDX license
> identifier for GPL-2.0+.
>
> As mentioned in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0
> license identifier to files with no license"), files with no license in
> the kernel are under default kernel license.

The default is GPLv2, not v2+.

>
> While I'm at it, all other libsas source code files are updated to use
> SPDX license identifier for GPL-2.0+.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
>
> diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig
> index 13739bfa..bdc6bce 100644
> --- a/drivers/scsi/libsas/Kconfig
> +++ b/drivers/scsi/libsas/Kconfig
> @@ -4,22 +4,7 @@
> # Copyright (C) 2005 Adaptec, Inc. All rights reserved.
> # Copyright (C) 2005 Luben Tuikov <luben_tuikov@adaptec.com>
> #
> -# This file is licensed under GPLv2.
> -#
> -# This program is free software; you can redistribute it and/or
> -# modify it under the terms of the GNU General Public License as
> -# published by the Free Software Foundation; version 2 of the
> -# License.
> -#
> -# This program is distributed in the hope that it will be useful,
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> -# General Public License for more details.
> -#
> -# You should have received a copy of the GNU General Public License
> -# along with this program; if not, write to the Free Software
> -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> -# USA
> +# SPDX-License-Identifier: GPL-2.0+

No, the above license is GPLv2 only, do NOT change the license of a file
unless you have permission to do so.

Also, the spdx line goes at the first line of the file.

> #
>
> config SCSI_SAS_LIBSAS
> diff --git a/drivers/scsi/libsas/Makefile b/drivers/scsi/libsas/Makefile
> index 5d51520..75998b7 100644
> --- a/drivers/scsi/libsas/Makefile
> +++ b/drivers/scsi/libsas/Makefile
> @@ -4,22 +4,7 @@
> # Copyright (C) 2005 Adaptec, Inc. All rights reserved.
> # Copyright (C) 2005 Luben Tuikov <luben_tuikov@adaptec.com>
> #
> -# This file is licensed under GPLv2.
> -#
> -# This program is free software; you can redistribute it and/or
> -# modify it under the terms of the GNU General Public License as
> -# published by the Free Software Foundation; version 2 of the
> -# License.
> -#
> -# This program is distributed in the hope that it will be useful,
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> -# General Public License for more details.
> -#
> -# You should have received a copy of the GNU General Public License
> -# along with this program; if not, write to the Free Software
> -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> -# USA
> +# SPDX-License-Identifier: GPL-2.0+

Again you changed the license, not good :(

Please do not make these types of changes unless you really know what
you are doing, it is not ok to change the license of files.

greg k-h