From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ahsan Hussain <ahsan_hussain@mentor.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: drm: understanding the kernel warning during drm_vblank_cleanup()
Date: Thu, 29 Nov 2018 17:19:28 +0200 [thread overview]
Message-ID: <20181129151928.GM9144@intel.com> (raw)
In-Reply-To: <6198455d-59b4-c4b0-94c1-6e0d460f2451@mentor.com>
On Thu, Nov 29, 2018 at 07:30:45PM +0500, Ahsan Hussain wrote:
> Hi folks,
>
> I'm new to DRM and trying to understand the warning in
> drivers/gpu/drm/drm_vblank.c during drm_vblank_cleanup().
>
> WARN_ON(READ_ONCE(vblank->enabled) &&
> drm_core_check_feature(dev, DRIVER_MODESET));
>
> Is the drm driver responsible for making sure that !(vblank->enabled) in
> the .unbind operation, or is this something related to userspace? What
> does the warning signify? Git history did not help here at all.
It signifies you haven't cleaned up things properly. Usually what
you would do is call drm_atomic_helper_shutdown() which will also
end up turnng vblank interrupts off, assuming you use
drm_vblank_on()/off() properly.
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2018-11-29 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:30 drm: understanding the kernel warning during drm_vblank_cleanup() Ahsan Hussain
2018-11-29 15:19 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129151928.GM9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ahsan_hussain@mentor.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox